fix(version): use debug.ReadBuildInfo for go-install builds#2
Merged
Conversation
When the binary is installed via `go install github.com/plinth-dev/cli/cmd/plinth@vX.Y.Z` the Makefile ldflags don't run, so Version and Commit stay empty. Read the module version + vcs.revision from runtime/debug.ReadBuildInfo so those binaries report a real version instead of "dev (commit none)". The Makefile-built path still wins when both fields are set explicitly. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
go install github.com/plinth-dev/cli/cmd/plinth@v0.1.0(the documented install path) bypasses the Makefile, soVersionandCommitstayed empty andplinth versionprintedplinth dev (commit none, go1.X)— confusing for anyone trying to confirm what they installed.This change adds a
runtime/debug.ReadBuildInfo()fallback that reads the module version andvcs.revisionsetting Go's toolchain stamps into binaries. The Makefile path still takes precedence when both fields are set.Test plan
go install github.com/plinth-dev/cli/cmd/plinth@v0.1.1should report a real version + commit.🤖 Generated with Claude Code