Skip to content

document .gitignore. Add .DS_Store to it while at it.#1025

Merged
wenkokke merged 8 commits intoplfa:devfrom
JacquesCarette:feature-gitignore
Jul 27, 2025
Merged

document .gitignore. Add .DS_Store to it while at it.#1025
wenkokke merged 8 commits intoplfa:devfrom
JacquesCarette:feature-gitignore

Conversation

@JacquesCarette
Copy link
Copy Markdown
Collaborator

As per title.

@JacquesCarette
Copy link
Copy Markdown
Collaborator Author

So it seems to pre-commit hook didn't like my changes to .gitignore. Are the rules to obey written down somewhere?

@wenkokke
Copy link
Copy Markdown
Collaborator

The pre-commit setup sorts it alphabetically, which is incorrect given that .gitignore exclusions and inclusions are order-dependent, so that should probably be taken out.

(The details are in the pre-commit config file. Follow the links to the various repositories to find out what code each action runs.)

@JacquesCarette
Copy link
Copy Markdown
Collaborator Author

This one is ready for review @wenkokke .

wenkokke
wenkokke previously approved these changes Jul 26, 2025
Comment thread .gitignore Outdated
@wenkokke
Copy link
Copy Markdown
Collaborator

I meant after their respective inclusions, eg, the zip inclusion after the general exclusion, but that's alright, we can fix that later.

@wenkokke wenkokke enabled auto-merge July 27, 2025 14:01
@wenkokke wenkokke added this pull request to the merge queue Jul 27, 2025
Merged via the queue into plfa:dev with commit dd82634 Jul 27, 2025
12 checks passed
noughtmare pushed a commit to noughtmare/plfa.github.io that referenced this pull request Oct 24, 2025
As per title.

---------

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Wen Kokke <wenkokke@users.noreply.github.com>
peterthiemann pushed a commit to proglang/plfa.github.io that referenced this pull request Jan 16, 2026
As per title.

---------

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Wen Kokke <wenkokke@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants