Skip to content

Fix end-to-end tests after TanStack Router upgrade - #788

Merged
tjementum merged 2 commits into
mainfrom
fix-end-to-end-tests
Nov 17, 2025
Merged

Fix end-to-end tests after TanStack Router upgrade#788
tjementum merged 2 commits into
mainfrom
fix-end-to-end-tests

Conversation

@tjementum

@tjementum tjementum commented Nov 17, 2025

Copy link
Copy Markdown
Member

Summary & Motivation

Fix 18 failing Playwright tests after upgrading TanStack Router from 1.90.0 to 1.134.18 and related frontend packages.

The router upgrade changed how component state persists and how UI interactions trigger change handlers:

  • OneTimeCodeInput components now retain locked state after errors, requiring explicit reset
  • React Aria Components Select elements need blurActiveElement() to trigger onSelectionChange
  • Network response events require polling due to async timing changes
  • Multiple concurrent dialogs/menus require specific selectors to disambiguate

Additionally, fix bug where user list page always included default URL parameters (orderBy=Name&sortOrder=Ascending&pageOffset=0) in the URL, preventing clean deep links to the page.

Checklist

  • I have added tests, or done manual regression tests
  • I have updated the documentation, if necessary

@tjementum tjementum self-assigned this Nov 17, 2025
@tjementum tjementum added the Bug Something isn't working label Nov 17, 2025
@tjementum tjementum moved this to 🏗 In Progress in Kanban board Nov 17, 2025
@sonarqubecloud

Copy link
Copy Markdown

@tjementum tjementum changed the title Fix end to end tests Fix end-to-end tests after TanStack Router upgrade Nov 17, 2025
@tjementum
tjementum marked this pull request as ready for review November 17, 2025 16:55
@tjementum
tjementum merged commit da11a43 into main Nov 17, 2025
22 of 25 checks passed
@tjementum
tjementum deleted the fix-end-to-end-tests branch November 17, 2025 16:56
@github-project-automation github-project-automation Bot moved this from 🏗 In Progress to ✅ Done in Kanban board Nov 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Bug Something isn't working

Projects

Status: ✅ Done

Development

Successfully merging this pull request may close these issues.

1 participant