[canary] coverage red-check — touched module missing from changeset (do not merge)#15
Closed
PaulNewling wants to merge 1 commit into
Closed
[canary] coverage red-check — touched module missing from changeset (do not merge)#15PaulNewling wants to merge 1 commit into
PaulNewling wants to merge 1 commit into
Conversation
There was a problem hiding this comment.
Code Review
This pull request introduces a canary changeset and a temporary comment in model/src/types.ts to test the coverage-gap check diagnostic. These changes are intended as a throwaway test and should not be merged. I have no feedback to provide as there are no review comments.
Collaborator
Author
|
Positive control confirmed: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Throwaway canary — do not merge. Close after the CI signal is read.
Positive control for the changeset-coverage fix on
github-ci@v4-beta: confirms a directly-edited package that is missing from the changeset still produces a redCheck changeset coveragestep.What this PR does
model/src/types.ts).…modelis touched-but-unbumped.build.yamltonode-simple-pnpm.yaml@v4-beta.Expected
The
Check changeset coveragestep should fail (exit 1) with…model (direct edit)in the "modified but not bumped" list. (Thechangeset coverage (diagnostic)job iscontinue-on-error: true, so the gap surfaces as a red step, verified via step-level conclusion.)Cleanup
Close without merging.