[canary] changeset-coverage devDependency fix — do not merge#14
Closed
PaulNewling wants to merge 1 commit into
Closed
[canary] changeset-coverage devDependency fix — do not merge#14PaulNewling wants to merge 1 commit into
PaulNewling wants to merge 1 commit into
Conversation
There was a problem hiding this comment.
Code Review
This pull request introduces a canary change to verify that the changeset-coverage check no longer flags model or workflow packages when build-tool devDependencies are bumped. It updates the version specifiers for @platforma-sdk/block-tools and @platforma-sdk/tengo-builder to use caret ranges in pnpm-workspace.yaml and pnpm-lock.yaml, and adds a temporary canary comment in ui/src/main.ts. There are no review comments, and I have no feedback to provide.
Collaborator
Author
|
Canary green: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Throwaway canary — do not merge. Close after the CI signal is read.
Validates the fix on
milaboratory/github-ci@v4-betathat scopes the changeset-coverage check's catalog rule to runtime deps only, so build-tool catalog bumps indevDependenciesstop producing false positives.What this PR reproduces
ui/src/main.ts).devDependencies:@platforma-sdk/block-toolsand@platforma-sdk/tengo-builder(pin → caret; same resolved versions, lockfile updated to match).build.yamltonode-simple-pnpm.yaml@v4-betato exercise the fix.What to check
The
changeset coverage (diagnostic)check should be green. On@v4it would flag…model(block-tools) and…workflow(tengo-builder) as "modified but not bumped" even though only the UI changed. With the fix those devDependency consumers are no longer flagged; the UI changeset satisfies coverage.Cleanup
Close without merging; the
@v4-betapin inbuild.yamlmust not reachmain.