-
Notifications
You must be signed in to change notification settings - Fork 0
feat: closeable info alerts on Sequence Properties (session-only) #13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
PaulNewling
wants to merge
7
commits into
main
Choose a base branch
from
paulnewling/fix/dismissable-info-messages-minimal
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+97
−38
Draft
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
cf1240c
feat: closeable info alerts with session-only dismissal
PaulNewling 082b684
chore: changeset for session-only closeable info alerts
PaulNewling 3deaf79
chore: bump @platforma-sdk/tengo-builder to 3.0.5
PaulNewling c5761c6
chore: bump @platforma-sdk/block-tools to 2.9.2
PaulNewling d99e41e
feat: hoist dismissedInfoMessages to module scope for tab persistence
PaulNewling 183be03
docs: correct dismissedInfoMessages lifetime comment
PaulNewling 4dc87db
feat: auto-prune dismissedInfoMessages on output change
PaulNewling File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,14 @@ | ||
| --- | ||
| '@platforma-open/milaboratories.sequence-properties.ui': minor | ||
| '@platforma-open/milaboratories.sequence-properties': minor | ||
| --- | ||
|
|
||
| Closeable info messages on the Main tab — session-only variant. The | ||
| advisory alerts emitted by the workflow now show a close button. | ||
| Dismissals live in a local UI ref and reset when the block UI unmounts | ||
| (project close, app reload). No `BlockData` change; no migration; the | ||
| block model is unchanged. | ||
|
|
||
| This is the minimal-surface alternative to a persisted-dismissal | ||
| approach. Pick this when you want "acknowledged for this session, fresh | ||
| on reopen" semantics and don't want to extend the block schema. |
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@update:model-valuehandler ignores the emitted boolean and callsdismissInfoMessageunconditionally. With:model-value="true"hardcoded, a close click will emitfalse— but ifPlAlertever emitsupdate:model-valuewithtrue(e.g., during internal re-sync or after an animation), every message would be dismissed the moment it mounts. Guarding on!vmakes the intent explicit and is safe against any emit direction.Prompt To Fix With AI