Skip to content

Add initial release for python-3.12.10-humanness with dependencies and configuration#75

Merged
AStaroverov merged 3 commits into
mainfrom
feat/add-promb
May 27, 2026
Merged

Add initial release for python-3.12.10-humanness with dependencies and configuration#75
AStaroverov merged 3 commits into
mainfrom
feat/add-promb

Conversation

@AStaroverov
Copy link
Copy Markdown
Contributor

@AStaroverov AStaroverov commented May 26, 2026

Greptile Summary

This PR introduces a new python-3.12.10-humanness run environment for antibody humanness scoring, wiring it into the pnpm workspace, catalogue, and checker whitelist infrastructure following the same conventions as the existing python-3.12.10-* sibling packages.

  • New environment package (python-3.12.10-humanness/): declares polars-lts-cpu==1.33.0 and promb==1.0.2 as Python dependencies; package.json mirrors the structure of other environments exactly.
  • Checker whitelists: empty JSON objects for Linux and Windows platforms; macOS whitelists include scipy import-failure exemptions (worth confirming these are actually needed transitively through promb).
  • Catalogue + workspace wiring: catalogue/package.json, pnpm-workspace.yaml, and pnpm-lock.yaml are all updated consistently to include the new package.

Confidence Score: 4/5

Safe to merge; the change adds a new standalone package and does not touch any shared build or runtime logic.

The package structure and workspace wiring are consistent with every other sibling environment. The two open questions — whether the macOS scipy whitelist entries are truly needed by promb's transitive closure, and whether polars-lts-cpu should be 1.33.1 to match the rest of the monorepo — are low-risk and won't block correctness, but they're worth a quick confirmation before the environment ships to users.

python-3.12.10-humanness/config.json (polars version) and checker/whitelists/python-3.12.10-humanness/macosx-*.json (scipy entries) deserve a second look.

Important Files Changed

Filename Overview
python-3.12.10-humanness/config.json Declares polars-lts-cpu==1.33.0 and promb==1.0.2; version of polars-lts-cpu is one patch behind other environments in the monorepo (1.33.1).
python-3.12.10-humanness/package.json New package manifest matching the structure of other python-3.12.10-* environments; no issues found.
checker/whitelists/python-3.12.10-humanness/macosx-aarch64.json Contains scipy whitelist entries but scipy is not a declared dependency; entries would be flagged as unused by the checker if promb does not transitively pull in scipy.
checker/whitelists/python-3.12.10-humanness/macosx-x64.json Same scipy whitelist concern as macosx-aarch64.json; error strings are correctly truncated at 100 chars by the auto-generator.
catalogue/package.json Adds the humanness environment to the catalogue reference and dependency list; structure matches existing entries.
pnpm-workspace.yaml Adds python-3.12.10-humanness to the workspace packages list; correct placement.
pnpm-lock.yaml Lock file correctly updated with humanness importer entries resolving catalog versions consistently with other packages.

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    A[pnpm-workspace.yaml] --> B[python-3.12.10-humanness]
    B --> C["config.json: polars-lts-cpu==1.33.0 + promb==1.0.2"]
    B --> D["package.json v0.1.0"]
    D --> E["build: pl-py-builder"]
    E --> F["pydist/ per platform"]
    F --> G["catalogue/package.json: 3.12.10-humanness reference"]
    B --> H["checker/whitelists/python-3.12.10-humanness/"]
    H --> I["linux + windows: empty whitelists"]
    H --> J["macos-aarch64 + macos-x64: scipy whitelist entries"]
Loading
Prompt To Fix All With AI
Fix the following 2 code review issues. Work through them one at a time, proposing concise fixes.

---

### Issue 1 of 2
checker/whitelists/python-3.12.10-humanness/macosx-aarch64.json:1-10
**Scipy whitelist entries with no apparent scipy dependency**

`config.json` only declares `polars-lts-cpu==1.33.0` and `promb==1.0.2`. The scipy whitelist entries in both macOS whitelist files (`macosx-aarch64.json` and `macosx-x64.json`) will only be exercised if `promb` brings in scipy as a transitive dependency. If it doesn't, the checker will report them as unused entries on every run (a warning but not a failure). Can you confirm whether `promb==1.0.2` pulls in scipy transitively? If it doesn't, these entries can be removed to keep the whitelist clean.

### Issue 2 of 2
python-3.12.10-humanness/config.json:3
**Inconsistent `polars-lts-cpu` version across the monorepo**

Both `python-3.12.10-parapred` and `python-3.12.10-scientific-slim` pin `polars-lts-cpu==1.33.1`, but this package pins `1.33.0`. If the older version is intentional (e.g., a compatibility constraint with `promb`), a comment would help; otherwise align with the rest of the workspace to avoid diverging polars behaviour.

```suggestion
    "dependencies": ["polars-lts-cpu==1.33.1", "promb==1.0.2"],
```

Reviews (1): Last reviewed commit: "Add initial release for python-3.12.10-h..." | Re-trigger Greptile

Greptile also left 2 inline comments on this PR.

Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a new Python 3.12.10 run environment (python-3.12.10-humanness) configured with polars-lts-cpu and promb for humanness scoring, along with its corresponding whitelists and workspace integrations. The review feedback correctly points out that the whitelist files for both macosx-aarch64 and macosx-x64 contain incomplete error message patterns for scipy.stats._unuran.unuran_wrapper, which are missing a closing single quote and a question mark at the end of 'SeedSequence.

Comment thread checker/whitelists/python-3.12.10-humanness/macosx-aarch64.json
Comment thread checker/whitelists/python-3.12.10-humanness/macosx-aarch64.json
Comment thread checker/whitelists/python-3.12.10-humanness/macosx-x64.json
Comment thread checker/whitelists/python-3.12.10-humanness/macosx-x64.json
Comment thread checker/whitelists/python-3.12.10-humanness/macosx-aarch64.json
Comment thread python-3.12.10-humanness/config.json Outdated
Comment thread python-3.12.10-humanness/config.json Outdated
@AStaroverov AStaroverov merged commit 845d806 into main May 27, 2026
5 of 43 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants