PFrames bump fix#74
Merged
Merged
Conversation
There was a problem hiding this comment.
Code Review
This pull request consolidates specific cupy_cuda12x wheel versions into a single wildcard pattern in the rapids whitelist. The review feedback correctly points out that during this consolidation, certain cudnn modules from the older wheel version were omitted, which could lead to import failures when older versions are tested. A suggestion is provided to include these missing modules in the wildcard whitelist.
vadimpiven
commented
May 26, 2026
| "cupyx.cutensor": "libcutensor.so.2: cannot open shared object file: No such file or directory" | ||
| }, | ||
| "cupy_cuda12x-14.0.1-cp312-cp312-manylinux2014_x86_64.whl": { | ||
| "cupy_cuda12x-*.whl": { |
Contributor
Author
There was a problem hiding this comment.
kevindetry-milaboratories
approved these changes
May 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Greptile Summary
This PR consolidates two version-pinned whitelist entries for
cupy_cuda12x(versions 13.6.0 and 14.0.1) into a single wildcard patterncupy_cuda12x-*.whl, matching the convention already used forcharset_normalizer,numba, andscipyin the same file.cudnn-related modules (cupy_backends.cuda.libs.cudnn,cupyx.cudnn) that were whitelisted only in 13.6.0 are dropped — this appears intentional since 14.0.1 had already removed them.Confidence Score: 4/5
Safe to merge; the wildcard consolidation is consistent with patterns already used in the file and the dropped cudnn entries reflect the 14.0.1 baseline.
The change is straightforward and follows existing conventions. The only notable detail is that two cudnn-related whitelist entries present in the old 13.6.0 block are absent from the new wildcard, which is fine as long as the bump targets 14.0.1+.
checker/whitelists/python-3.12.10-rapids/linux-x64.json — confirm the cudnn module omission is intentional for the target cupy version.
Important Files Changed
Comments Outside Diff (1)
checker/whitelists/python-3.12.10-rapids/linux-x64.json, line 12-23 (link)The 13.6.0 entry whitelisted
cupy_backends.cuda.libs.cudnnandcupyx.cudnn(both failing withlibcudnn.so.8: cannot open shared object file), but the new wildcardcupy_cuda12x-*.whlomits them. If the bumped version or a future version re-introducescudnnas a hard import, the checker will report a new unexpected failure not covered by the whitelist. This is low-risk if the bump targets 14.0.1+ (which already lacked those entries), but worth confirming the dropped entries are intentional.Prompt To Fix With AI
Prompt To Fix All With AI
Reviews (1): Last reviewed commit: "PFrames bump fix" | Re-trigger Greptile