Fix checker after PFrames bump#73
Merged
Merged
Conversation
There was a problem hiding this comment.
Code Review
This pull request updates the cupy_cuda12x whitelist entry in the python-3.12.10 linux-x64 configuration to version 14.1.0, removing older versions. The reviewer suggested using a wildcard pattern (e.g., "cupy_cuda12x-*.whl") instead of a hardcoded version to avoid manual whitelist updates whenever the package is bumped.
dcb189e to
0f064f9
Compare
vadimpiven
commented
May 26, 2026
| "cupyx.cutensor": "libcutensor.so.2: cannot open shared object file: No such file or directory" | ||
| }, | ||
| "cupy_cuda12x-14.0.1-cp312-cp312-manylinux2014_x86_64.whl": { | ||
| "cupy_cuda12x-*.whl": { |
Contributor
Author
There was a problem hiding this comment.
julenmendieta
approved these changes
May 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Greptile Summary
Updates the python-3.12.10 linux-x64 import-checker whitelist to match a PFrames package bump: cupy whitelist entries for versions 13.6.0 and 14.0.1 are replaced by a 14.1.0 entry, and new suppressions are added for
librmm_cu1225.6.0,libcudf_cu1225.6.0, andtorch2.9.1+cpu.cudnnsuppressions that were present in 14.0.1; worth confirming this is intentional and that those modules now import cleanly.Confidence Score: 4/5
Safe to merge; the change is a straightforward whitelist update with one open question about intentionally omitted cudnn suppressions.
The whitelist update is mechanical and low-risk. The only open question is whether the two cudnn module suppressions present in 14.0.1 were deliberately dropped for 14.1.0, or accidentally omitted. If they were accidentally omitted and cupy 14.1.0 still fails to load those modules, the checker would start rejecting valid environments. Everything else in the change looks correct and consistent with prior entries.
checker/whitelists/python-3.12.10/linux-x64.json — specifically the cupy 14.1.0 block and its missing cudnn entries.
Important Files Changed
Flowchart
%%{init: {'theme': 'neutral'}}%% flowchart TD A[PFrames bump] --> B[cupy bumped to 14.1.0] A --> C[librmm_cu12 25.6.0 added] A --> D[libcudf_cu12 25.6.0 added] A --> E[torch 2.9.1+cpu added] B --> F[Remove cupy 13.6.0 whitelist entry] B --> G[Remove cupy 14.0.1 whitelist entry] B --> H[Add cupy 14.1.0 whitelist entry] H --> I{cudnn suppressions?} I -->|Present in 14.0.1| J[cupy_backends.cuda.libs.cudnn\ncupyx.cudnn] I -->|Missing in 14.1.0| K[Omitted — intentional?]Comments Outside Diff (1)
checker/whitelists/python-3.12.10/linux-x64.json, line 5-16 (link)The 14.0.1 (and 13.6.0) entries included two cudnn-related suppressions —
cupy_backends.cuda.libs.cudnnandcupyx.cudnn— that are not present in the new 14.1.0 block. If cupy 14.1.0 genuinely resolved those missing-library errors (i.e. the modules now load cleanly without libcudnn.so.8 on the path) then the omission is correct. But if the errors still occur at runtime, the checker will flag them as unexpected failures on any environment running 14.1.0. Could you confirm whether these two modules were intentionally removed?Prompt To Fix With AI
Prompt To Fix All With AI
Reviews (1): Last reviewed commit: "Fix checker after PFrames bump" | Re-trigger Greptile