Skip to content

SDK Update#32

Open
mzueva wants to merge 1 commit into
mainfrom
mzueva/update-sdk-20260506
Open

SDK Update#32
mzueva wants to merge 1 commit into
mainfrom
mzueva/update-sdk-20260506

Conversation

@mzueva
Copy link
Copy Markdown
Contributor

@mzueva mzueva commented May 6, 2026

No description provided.

Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates several SDK and internal package versions and adds a linker formatter to the overlapTable and sampleTable configurations. The reviewer recommends returning an empty string instead of undefined in the formatter to properly suppress linker names in column headers and suggests refactoring the duplicated logic into a shared constant.

Comment thread model/src/index.ts
primaryJoinType: "full",
tableState: ctx.data.overlapTableState,
labelsOptions: {
formatters: { linker: () => undefined },
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Returning undefined from the linker formatter typically instructs the SDK to use the default label formatting. If the intention is to suppress the linker name in the column headers (e.g., to keep them concise), you should return an empty string '' instead. Additionally, this configuration is duplicated in the sampleTable definition; consider extracting it to a shared constant to maintain consistency and reduce duplication.

Suggested change
formatters: { linker: () => undefined },
formatters: { linker: () => '' },
References
  1. Avoid complex and duplicated logic for ensuring unique column labels. Simplify the implementation, for example, by refactoring it into a single function that adds a numeric suffix to duplicates.

Comment thread model/src/index.ts
},
},
labelsOptions: {
formatters: { linker: () => undefined },
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

As with the overlapTable definition, if the goal is to hide the linker name, return '' instead of undefined. This configuration is duplicated and should ideally be refactored into a shared constant.

Suggested change
formatters: { linker: () => undefined },
formatters: { linker: () => '' },
References
  1. Avoid complex and duplicated logic for ensuring unique column labels. Simplify the implementation, for example, by refactoring it into a single function that adds a numeric suffix to duplicates.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant