SDK Update#32
Conversation
There was a problem hiding this comment.
Code Review
This pull request updates several SDK and internal package versions and adds a linker formatter to the overlapTable and sampleTable configurations. The reviewer recommends returning an empty string instead of undefined in the formatter to properly suppress linker names in column headers and suggests refactoring the duplicated logic into a shared constant.
| primaryJoinType: "full", | ||
| tableState: ctx.data.overlapTableState, | ||
| labelsOptions: { | ||
| formatters: { linker: () => undefined }, |
There was a problem hiding this comment.
Returning undefined from the linker formatter typically instructs the SDK to use the default label formatting. If the intention is to suppress the linker name in the column headers (e.g., to keep them concise), you should return an empty string '' instead. Additionally, this configuration is duplicated in the sampleTable definition; consider extracting it to a shared constant to maintain consistency and reduce duplication.
| formatters: { linker: () => undefined }, | |
| formatters: { linker: () => '' }, |
References
- Avoid complex and duplicated logic for ensuring unique column labels. Simplify the implementation, for example, by refactoring it into a single function that adds a numeric suffix to duplicates.
| }, | ||
| }, | ||
| labelsOptions: { | ||
| formatters: { linker: () => undefined }, |
There was a problem hiding this comment.
As with the overlapTable definition, if the goal is to hide the linker name, return '' instead of undefined. This configuration is duplicated and should ideally be refactored into a shared constant.
| formatters: { linker: () => undefined }, | |
| formatters: { linker: () => '' }, |
References
- Avoid complex and duplicated logic for ensuring unique column labels. Simplify the implementation, for example, by refactoring it into a single function that adds a numeric suffix to duplicates.
No description provided.