add dataplane checks

.github/workflows/checkpatch.yml

@@ -0,0 +1,16 @@
+# Run checkpatch on pull requests.
+# See https://github.com/webispy/checkpatch-action
+
+name: checkpatch
+
+on: pull_request
+
+jobs:
+  checkpatch:
+    name: checkpatch
+    runs-on: ubuntu-latest
+    steps:
+      - uses: actions/checkout@v1
+      - name: Run checkpatch review
+        uses: webispy/checkpatch-action@master
+      - run: echo "Job status is ${{ job.status }}."

.github/workflows/checkpatch2.yml

@@ -0,0 +1,42 @@
+name: checkpatch2
+
+on: pull_request
+
+jobs:
+  checkpatch:
+
+    runs-on: ubuntu-latest
+
+#    container:
+#      image: webispy/checkpatch
+
+    steps:
+    - uses: actions/checkout@v2
+
+    - name: pwd
+      run: pwd
+
+    - name: git fetch
+      run: git fetch --no-tags --prune origin +refs/heads/*:refs/remotes/origin/*
+
+    - name: show
+      run: |
+        echo "GITHUB_BASE_REF=${GITHUB_BASE_REF}"
+        echo "GITHUB_HEAD_REF=${GITHUB_HEAD_REF}"
+        echo "PATH=${PATH}"
+        which checkpatch.pl
+#        find / -name checkpatch.pl
+#        ls -l /usr/bin/checkpatch.pl
+#        /usr/bin/checkpatch.pl -h
+#        checkpatch.pl
+
+
+#    - name: Run DPDK checkpatches.sh review
+#      uses: webispy/checkpatch-action@master
+#      env:
+#        DPDK_CHECKPATCH_PATH: /usr/bin/checkpatch.pl
+#        CHECKPATCH_COMMAND: ./scripts/checkpatch_wrapper.sh origin/${GITHUB_BASE_REF} origin/${GITHUB_HEAD_REF}
+
+    - name: run checkpatch
+      run: ./scripts/checkpatch_wrapper.sh origin/${GITHUB_BASE_REF} origin/${GITHUB_HEAD_REF}
+    - run: echo "Job status is ${{ job.status }}."

.github/workflows/commit_size_check.yml

@@ -0,0 +1,30 @@
+# Run size check on pull requests.
+
+name: size check
+
+on: pull_request
+
+jobs:
+  size_check:
+
+    runs-on: ubuntu-latest
+
+    steps:
+    - uses: actions/checkout@v2
+
+    - name: install
+      run: sudo apt-get install git-buildpackage osc debhelper
+
+    - name: which
+      run: which gbp osc dh
+
+    - name: git fetch
+      run: git fetch --no-tags --prune origin +refs/heads/*:refs/remotes/origin/*
+
+    - name: gbp
+      run: pwd && gbp buildpackage --git-verbose --git-ignore-branch -S --no-check-builddeps -us -uc
+
+    - name: run size check
+      run: ./scripts/commit_size_check.sh origin/${GITHUB_BASE_REF} origin/${GITHUB_HEAD_REF}
+
+    - run: echo "Job status is ${{ job.status }}."

.github/workflows/gitlint.yaml

@@ -0,0 +1,21 @@
+# Run gitlint on pull requests.
+# See https://github.com/marketplace/actions/gitlint-action
+
+name: GitLint
+
+on: pull_request
+
+jobs:
+  gitlint:
+    name: GitLint
+    runs-on: ubuntu-latest
+    steps:
+      - name: Lint commits, branches, and pull requests
+        uses: aschbacd/gitlint-action@v1.0.0
+        with:
+          github-token: ${{ secrets.GITHUB_TOKEN }}
+          commit-message-body-max-length: 72
+          commit-message-subject-max-length: 50
+          prohibit-unknown-commit-authors: true
+          prohibit-unknown-commit-committers: true
+      - run: echo "Job status is ${{ job.status }}."

.github/workflows/gitlint0.yml

@@ -0,0 +1,29 @@
+# Run gitlint on pull requests.
+
+name: gitlint0
+
+on: pull_request
+
+jobs:
+  gitlint:
+
+    runs-on: ubuntu-latest
+
+    container:
+      image: jorisroovers/gitlint
+
+    steps:
+    - uses: actions/checkout@v2
+    - name: git fetch
+      run: git fetch --no-tags --prune origin +refs/heads/*:refs/remotes/origin/*
+    - name: echo
+      run: |
+          echo "GITHUB_HEAD_REF=${GITHUB_HEAD_REF}"
+          echo "GITHUB_BASE_REF=${GITHUB_BASE_REF}"
+    - name: head
+      run: git log origin/${GITHUB_HEAD_REF}
+    - name: base
+      run: git log origin/${GITHUB_BASE_REF}
+    - name: run gitlint
+      run: gitlint --commits origin/${GITHUB_BASE_REF}..origin/${GITHUB_HEAD_REF}
+    - run: echo "Job status is ${{ job.status }}."

.github/workflows/jrgitlint.yml

@@ -0,0 +1,44 @@
+name: JR GitLint
+
+on: [push, pull_request, workflow_dispatch]
+
+jobs:                                                                            
+  gitlint:                                                                       
+
+    runs-on: ubuntu-latest                                                       
+
+    container:                                                                   
+      image: jorisroovers/gitlint                                                
+
+    steps:                                                                       
+    - uses: actions/checkout@v2                                                  
+    - name: git fetch                                                              
+      run: git fetch --no-tags --prune origin +refs/heads/*:refs/remotes/origin/*
+    - name: git show
+      run: |
+          echo "GITHUB_HEAD_REF=${GITHUB_HEAD_REF}"
+          echo "GITHUB_BASE_REF=${GITHUB_BASE_REF}"
+          echo "github.event.pull_request.head.ref=${{ github.event.pull_request.head.ref }}"
+          echo "github.event.pull_request.base.ref=${{ github.event.pull_request.base.ref }}"
+          echo "github.event.pull_request.head.sha=${{ github.event.pull_request.head.sha }}"
+          echo "github.event.pull_request.base.sha=${{ github.event.pull_request.base.sha }}"
+#    - name: git show H
+#      run: git show ${{ github.event.pull_request.head.sha }}
+#     run: git show ${{ GITHUB_HEAD_REF }}
+#    - name: git show B
+#      run: git show ${{ github.event.pull_request.head.sha }}
+#     run: git show ${{ GITHUB_BASE_REF }}
+    - name: git log 1
+      run: git log --pretty=oneline ${{ github.event.pull_request.base.sha }}..${{ github.event.pull_request.head.sha }}
+    - name: git log 2
+      run: git log --pretty=oneline origin/${GITHUB_BASE_REF}..origin/${GITHUB_HEAD_REF}
+    - name: run gitlint 1
+      run: gitlint --commits ${{ github.event.pull_request.base.sha }}..${{ github.event.pull_request.head.sha }}
+    - name: run gitlint 2
+      run: gitlint --commits origin/${GITHUB_BASE_REF}..origin/${GITHUB_HEAD_REF}
+#     run: gitlint --commits origin/${GITHUB_BASE_REF}..origin/${GITHUB_HEAD_REF}  
+    - run: echo "Job status is ${{ job.status }}." 
+
+#     run: gitlint --commits origin/${GITHUB_BASE_REF}..origin/${GITHUB_HEAD_REF}  
+#     run: git fetch --no-tags --prune --depth=1 origin +refs/heads/*:refs/remotes/origin/*
+# run: git log --abbrev-commit ${GITHUB_BASE_REF}..${GITHUB_HEAD_REF}

scripts/commit_size_check.sh

@@ -0,0 +1,51 @@
+#! /bin/bash
+
+# Copyright (c) 2021, AT&T Intellectual Property.  All rights reserved.
+
+usage () {
+    echo "Usage: $(basename $0) target source" >&2
+    echo "target: something like 'origin/master'" >&2
+    echo "source: something like 'bugfix/foo' or 'feature/bar'" >&2
+}
+
+[ "$#" -ne 2 ] && { usage; exit 1; }
+
+TARGET="$1" # most likely "origin/master"
+SOURCE="$2" # most likely "bugfix/foo" or "feature/bar"
+
+MAX_CHANGED_LINES_ALLOWED=400
+
+GIT_SOURCE_HASH=$(git rev-list -n1 "$SOURCE")
+GIT_TARGET_HASH=$(git rev-list -n1 "$TARGET")
+GIT_MERGE_BASE=$(git merge-base $GIT_SOURCE_HASH $GIT_TARGET_HASH)
+
+ALL_COMMITS=$(git rev-list --no-merges \
+		  "$GIT_MERGE_BASE..$GIT_SOURCE_HASH")
+for COMMIT in $ALL_COMMITS
+do
+    COMMIT_CHANGES=$(git show --format=format:'' --shortstat "$COMMIT")
+
+    REGEX_INSERTIONS=".* ([0-9]+) insertions.*"
+    [[ "$COMMIT_CHANGES" =~ $REGEX_INSERTIONS ]]
+    INSERTIONS="${BASH_REMATCH[1]}"
+
+    REGEX_DELETIONS=".* ([0-9]+) deletions.*"
+    [[ "$COMMIT_CHANGES" =~ $REGEX_DELETIONS ]]
+    DELETIONS="${BASH_REMATCH[1]}"
+
+    TOTAL_CHANGE=$(( INSERTIONS + DELETIONS ))
+
+    #echo "$COMMIT $COMMIT_CHANGES"
+    #echo "Insertions:$INSERTIONS Deletions:$DELETIONS"
+    #echo "Total Change:$TOTAL_CHANGE"
+
+    if [ "$TOTAL_CHANGE" -gt "$MAX_CHANGED_LINES_ALLOWED" ]; then
+	echo "$COMMIT is greater than $MAX_CHANGED_LINES_ALLOWED lines,"\
+	     "please consider splitting into multiple commits."
+	COMMIT_TOO_LARGE=true
+    fi
+done
+
+if [ "$COMMIT_TOO_LARGE" = "true" ]; then
+    exit 1
+fi

src/npf/dpi/dpi.c

@@ -9,6 +9,8 @@
  * SPDX-License-Identifier: LGPL-2.1-only
  */
 
+// blah blah blah, this line will be too long and checkpatch will complain about it.
+
 #include <errno.h>
 #include <stdbool.h>
 #include <string.h>