Skip to content

fix: Resolves the issue regarding copy link in form#53

Open
SwastikKasera wants to merge 8 commits into
piyushgarg-dev:mainfrom
SwastikKasera:main
Open

fix: Resolves the issue regarding copy link in form#53
SwastikKasera wants to merge 8 commits into
piyushgarg-dev:mainfrom
SwastikKasera:main

Conversation

@SwastikKasera

@SwastikKasera SwastikKasera commented Oct 8, 2023

Copy link
Copy Markdown

What does this PR do?

This PR fix the copy button to copy the link of the forms.

Fixes #52

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • I haven't commented my code, particularly in hard-to-understand areas
  • I haven't checked if my changes generate no new warnings
  • I haven't added tests that prove my fix is effective or that my feature works
  • I haven't checked if new and existing unit tests pass locally with my changes

@github-actions

github-actions Bot commented Oct 8, 2023

Copy link
Copy Markdown

Thank you for following the naming conventions! 🙏

@SwastikKasera SwastikKasera changed the title FIX : Copy button fix : Copy button Oct 8, 2023
@SwastikKasera SwastikKasera changed the title fix : Copy button fix: Resolves the issue regarding copy link in form Oct 8, 2023
Comment thread components/Dashboard/FormPane.tsx Outdated
Comment thread components/Dashboard/FormPane.tsx Outdated
import { useRouter } from 'next/router'
import { useState } from 'react'

import toast from 'react-hot-toast'

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Move the import statement above as we're separating our imports from built-in libs to custom libs

@SwastikKasera

SwastikKasera commented Oct 9, 2023

Copy link
Copy Markdown
Author

Sure, @hemantwasthere. I am working on it

@SwastikKasera

Copy link
Copy Markdown
Author

I have implemented the suggestion, please review

import Link from 'next/link'
import { useRouter } from 'next/router'
import { useState } from 'react'
import toast from 'react-hot-toast'

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

put a space of a line between the imports
like this:

import Link from 'next/link'
import { useRouter } from 'next/router'
import { useState } from 'react'
// space here
import { Checkbox } from '@/components/ui/checkbox'
import {
  Tooltip,
  TooltipContent,
  TooltipProvider,
  TooltipTrigger,
} from '@/components/ui/tooltip'

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done sir

Comment thread gql/graphql.ts

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Discard all the other file changes except FormPane.tsx

@github-actions github-actions Bot added 🚨 merge conflict Merge Conflict and removed 🚨 merge conflict Merge Conflict labels Oct 10, 2023
@github-actions

Copy link
Copy Markdown

Hey there, there is a merge conflict, can you take a look?

@github-actions github-actions Bot added the 🚨 merge conflict Merge Conflict label Oct 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🚨 merge conflict Merge Conflict

Projects

None yet

Development

Successfully merging this pull request may close these issues.

BUG : Copy button not working

2 participants