fix: Corrected routes and refactored code#257
Open
sohan9819 wants to merge 1 commit into
Open
Conversation
- Corrected route for about page. - Moved all the components of about and home page to a separate folder.
There was a problem hiding this comment.
Good work @sohan9819 😃,
Thank you for raising the PR. Soon, the owner/maintainers will review it and offer feedback/suggestions.
Meanwhile if you enjoy contributing to the project, please consider giving it a star ⭐.
|
Thank you for following the naming conventions! 🙏 |
Contributor
Author
|
@hemantwasthere should I put the constants in a separate file ? |
hemantwasthere
requested review from
hemantwasthere
and removed request for
hemantwasthere
October 28, 2023 13:52
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes #256
Checkout the refactored code at
pages/index.tsxpages/about/index.tsxcomponets/LayoutRequirement/Documentation
Type of change
How should this be tested?
Mandatory Tasks