Skip to content

fix: Corrected routes and refactored code#257

Open
sohan9819 wants to merge 1 commit into
piyushgarg-dev:mainfrom
sohan9819:bug/refactor-and-route-corrections
Open

fix: Corrected routes and refactored code#257
sohan9819 wants to merge 1 commit into
piyushgarg-dev:mainfrom
sohan9819:bug/refactor-and-route-corrections

Conversation

@sohan9819

Copy link
Copy Markdown
Contributor

What does this PR do?

  • Corrected route for about page.
  • Moved all the components of about and home page to there individual files in the component/Layout folder.

NOTE: I have not removed the old files(pages/template/ebraj) since we have yet to finalise the blogs and contact page

Fixes #256

image

Checkout the refactored code at

  • pages/index.tsx
  • pages/about/index.tsx
  • componets/Layout

Requirement/Documentation

  • If there is a requirement document, please, share it here.
  • If there is ab UI/UX design document, please, share it here.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • Chore (refactoring code, technical debt, workflow improvements)

How should this be tested?

Mandatory Tasks

  • Make sure you have self-reviewed the code. A decent size PR without self-review might be rejected.

 - Corrected route for about page.
- Moved all the components of about and home page to a separate folder.

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work @sohan9819 😃,

Thank you for raising the PR. Soon, the owner/maintainers will review it and offer feedback/suggestions.
Meanwhile if you enjoy contributing to the project, please consider giving it a star ⭐.

@github-actions github-actions Bot added the bug Something isn't working label Oct 24, 2023
@github-actions

github-actions Bot commented Oct 24, 2023

Copy link
Copy Markdown

Thank you for following the naming conventions! 🙏

@sohan9819 sohan9819 changed the title Corrected routes and refactored code fix: Corrected routes and refactored code Oct 24, 2023
@sohan9819

Copy link
Copy Markdown
Contributor Author

@hemantwasthere should I put the constants in a separate file ?

@hemantwasthere
hemantwasthere requested review from hemantwasthere and removed request for hemantwasthere October 28, 2023 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: Route Corrections and Code Refactoring for About and Landing Page

1 participant