fix: Redirect to signIn page when accessing routes without signi…#173
Open
Nick-h4ck3r wants to merge 2 commits into
Open
fix: Redirect to signIn page when accessing routes without signi…#173Nick-h4ck3r wants to merge 2 commits into
Nick-h4ck3r wants to merge 2 commits into
Conversation
github-actions
Bot
added
bug
|
Thank you for following the naming conventions! 🙏 |
Nick-h4ck3r
changed the title
Author
|
hey, I've resolved the conflicts. You can merge this PR now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
If user is not signed in, we will redirect to them to Sign In page. Currently, anyone was able to access routes like /dashboard, /dashboard/undefined/forms, dashboard/undefined, etc.
Fixes #102
Here's a loom video for visual changes to speed up reviews
Loom Video: https://www.loom.com/share/0e27cb4415b04f47a9b611978dde56b7
Type of change
How should this be tested?
Currently, if you go to any below addresses, you can see a rendered page with just layout. Ofcourse, data is not populated. But, in this push, I've fixed this, and instead user is redirected to sign in first.
Mandatory Tasks