Skip to content

fix: user enter any other domain in URL ( /dashboard/xyz ) then load first project data#157

Open
DeepMakhasana wants to merge 1 commit into
piyushgarg-dev:mainfrom
DeepMakhasana:fix/project-domain-change-from-url
Open

fix: user enter any other domain in URL ( /dashboard/xyz ) then load first project data#157
DeepMakhasana wants to merge 1 commit into
piyushgarg-dev:mainfrom
DeepMakhasana:fix/project-domain-change-from-url

Conversation

@DeepMakhasana

Copy link
Copy Markdown

What does this PR do?

A user enters any other domain in the URL like ( /dashboard/xyz )
that time replace the URL with ( /dashboard/{ first-project-name } ) and load first project data

Fixes #155

Solved video

fix-155-review-app.mp4

@github-actions github-actions Bot added the bug Something isn't working label Oct 14, 2023
@github-actions

Copy link
Copy Markdown

Thank you for following the naming conventions! 🙏

@github-actions

Copy link
Copy Markdown

Hey there, there is a merge conflict, can you take a look?

@github-actions github-actions Bot added the 🚨 merge conflict Merge Conflict label Oct 19, 2023

@hemantwasthere hemantwasthere left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please discard other file changes except project.tsx and also resolve the conflicts

@hemantwasthere

Copy link
Copy Markdown
Collaborator

LGTM, if @piyushgarg-dev approves then we can merge this PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working 🚨 merge conflict Merge Conflict

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: When user enter any other domain in URL ( /dashboard/xyz ) then project data does not load

2 participants