feat(checkers): add missing_replica_identity#25
Merged
Conversation
Flags tables whose effective REPLICA IDENTITY is empty — UPDATE/DELETE will not replicate via logical decoding. Two cases match: - relreplident = 'd' (default) but no PRIMARY KEY exists, or - relreplident = 'n' (explicit NOTHING). Strictly narrower than missing_primary_key: tables with explicit REPLICA IDENTITY USING INDEX or FULL are not flagged here, even if they lack a PK. Skips temp / unlogged tables (never replicated) and partition children (identity is inherited from the parent). Severity warning, matching missing_primary_key. The rule doc walks through fixes (ADD PRIMARY KEY, USING INDEX, FULL) and notes when to disable for teams not using logical replication. Updates README.md / docs/rules/README.md / docs/severity.md to list the new rule. Drops it from the ROADMAP medium-term list.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Flags tables whose effective REPLICA IDENTITY is empty — UPDATE/DELETE will not replicate via logical decoding. Two cases match:
Strictly narrower than missing_primary_key: tables with explicit REPLICA IDENTITY USING INDEX or FULL are not flagged here, even if they lack a PK. Skips temp / unlogged tables (never replicated) and partition children (identity is inherited from the parent).
Severity warning, matching missing_primary_key. The rule doc walks through fixes (ADD PRIMARY KEY, USING INDEX, FULL) and notes when to disable for teams not using logical replication.
Updates README.md / docs/rules/README.md / docs/severity.md to list the new rule. Drops it from the ROADMAP medium-term list.