feat(checkers): add json_over_jsonb#17
Merged
Merged
Conversation
Flags columns typed as 'json' instead of 'jsonb'. The 'json' type stores the literal text and reparses on every read; 'jsonb' parses once at write, normalizes the structure, and supports GIN indexing plus the containment / existence operators (@>, ?, ?&, ?|). The only thing 'json' preserves that 'jsonb' doesn't is the input bytes — almost no application needs that, and the few that do (signature verification) usually want plain text storage instead. Severity: warning. The cost (no indexing, slower reads) is real and accumulates as the table grows, but the schema isn't currently broken. Tests: clean (jsonb), positive (json), mixed-type (only the json column flagged), dropped column ignored. 16/16 against PG 10/13/15/17.
pirr
force-pushed
the
feat/checker-json-over-jsonb
branch
from
fcce0b9 to
5bffa63
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Flags columns typed as 'json' instead of 'jsonb'. The 'json' type stores the literal text and reparses on every read; 'jsonb' parses once at write, normalizes the structure, and supports GIN indexing plus the containment / existence operators (@>, ?, ?&, ?|). The only thing 'json' preserves that 'jsonb' doesn't is the input bytes — almost no application needs that, and the few that do (signature verification) usually want plain text storage instead.
Severity: warning. The cost (no indexing, slower reads) is real and accumulates as the table grows, but the schema isn't currently broken.
Tests: clean (jsonb), positive (json), mixed-type (only the json column flagged), dropped column ignored. 16/16 against PG 10/13/15/17.