feat(checkers): add varchar_length#16
Merged
Merged
Conversation
Flags 'varchar(N)' columns. In Postgres, varchar(N), varchar, and text all use identical storage — there's no performance benefit to a length cap. The cap is enforced as a write-time constraint, which is fine if you actually want it, but most varchar(N) columns are fossils carried over from MySQL/SQL Server habits where length actually matters. Bare 'varchar' (no length) and 'text' are not flagged. Severity: info. Capped varchar isn't broken; teams sometimes use it deliberately. Run periodically rather than blocking PRs on it. Reports the actual length cap in extra['length'] so consumers can prioritize suspiciously round numbers (255, 100, etc.). Tests: clean (text), clean (unbounded varchar), positive (varchar(255)), mixed (only the capped column flagged), dropped column ignored. 20/20 against PG 10/13/15/17.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Flags 'varchar(N)' columns. In Postgres, varchar(N), varchar, and text all use identical storage — there's no performance benefit to a length cap. The cap is enforced as a write-time constraint, which is fine if you actually want it, but most varchar(N) columns are fossils carried over from MySQL/SQL Server habits where length actually matters. Bare 'varchar' (no length) and 'text' are not flagged.
Severity: info. Capped varchar isn't broken; teams sometimes use it deliberately. Run periodically rather than blocking PRs on it. Reports the actual length cap in extra['length'] so consumers can prioritize suspiciously round numbers (255, 100, etc.).
Tests: clean (text), clean (unbounded varchar), positive (varchar(255)), mixed (only the capped column flagged), dropped column ignored. 20/20 against PG 10/13/15/17.