make csi-node container cli values patchable#1018
Open
camh- wants to merge 1 commit into
Open
Conversation
Make the values of the flags passed to containers of the csi-node DaemonSet patchable by taking those values from environment variables. Environment variables are much easier to patch with LinstorCluster patches than the args array. This is the same way it is done with the csi-controller containers. Update docs/how-to/k0s.md to patch the `KUBELET_REGISTRATION_PATH` environment variable instead of the whole set of args. Signed-off-by: Cam Hutchison <camh@xdna.net>
Contributor
Author
|
I've created this change as I have found some of the csi-node logs to be a bit too chatty for my liking and wanted to turn them down a bit, but it is hard to patch an element of an array (the args with --v=5). The controller has a method of patching the env var value, so figured it would be good to have on the node too. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make the values of the flags passed to containers of the csi-node
DaemonSet patchable by taking those values from environment variables.
Environment variables are much easier to patch with LinstorCluster
patches than the args array. This is the same way it is done with the
csi-controller containers.
Update docs/how-to/k0s.md to patch the
KUBELET_REGISTRATION_PATHenvironment variable instead of the whole set of args.