Skip to content

Switch to OIDC Trusted Publishers #71

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pipedrive-public-gha-bot merged 1 commit into from
May 22, 2026
Merged

Switch to OIDC Trusted Publishers #71

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions .github/workflows/cicd_npm-publish.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,11 @@ jobs:
publish:
if: ${{ github.event.label.name == 'npm-ready-for-publish' }}
uses: pipedrive-actions/github-actions-workflows/.github/workflows/reusable_cicd-npm-publish.yml@master
permissions:
id-token: write
contents: write
with:
revision: ${{ github.event.pull_request.head.ref }}
supported_versions: '[22]'

@siirimangus siirimangus May 22, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In .nvmrc the Node version was set to 24. Is it correct that here it stays unchanged? Also, in package.json the version is still set to >=22 (yes, the 24 is covered :), but would it make sense to change it there as well?)

@Moser-ss Moser-ss May 22, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With this setup, the publish workflow runs the tests with version 24 (main version based on the .nvmrc) and runs with version 22, which respects the package.json

use_trusted_publisher: true
secrets: inherit
2 changes: 1 addition & 1 deletion .nvmrc
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
22
24
Loading