Skip to content

Fix TCP chunk: seqNum/ackNum and Clone#387

Merged
sirzooro merged 1 commit into
pion:mainfrom
sirzooro:tcp_chunk_fix
Jul 6, 2026
Merged

Fix TCP chunk: seqNum/ackNum and Clone#387
sirzooro merged 1 commit into
pion:mainfrom
sirzooro:tcp_chunk_fix

Conversation

@sirzooro

@sirzooro sirzooro commented Jul 5, 2026

Copy link
Copy Markdown
Contributor

Description

Self-contained improvements to the existing chunkTCP struct.

  • Add seqNum and ackNum fields (replacing commented-out stubs).
  • Fix Clone() to copy flags, seqNum, ackNum, tag, and duplicate — previously these were silently dropped on clone.
  • Use the tcp package constant in Network() instead of raw string "tcp".

Split out from #375

@codecov

codecov Bot commented Jul 5, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 84.78%. Comparing base (1bb98ad) to head (f07aab1).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #387      +/-   ##
==========================================
+ Coverage   84.63%   84.78%   +0.15%     
==========================================
  Files          38       38              
  Lines        3117     3122       +5     
==========================================
+ Hits         2638     2647       +9     
+ Misses        348      345       -3     
+ Partials      131      130       -1     
Flag Coverage Δ
go 84.78% <100.00%> (+0.15%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@sirzooro sirzooro requested a review from JoTurk July 5, 2026 08:31
@sirzooro

sirzooro commented Jul 6, 2026

Copy link
Copy Markdown
Contributor Author

Thanks

@sirzooro sirzooro merged commit a4a04ed into pion:main Jul 6, 2026
18 checks passed
@sirzooro sirzooro deleted the tcp_chunk_fix branch July 6, 2026 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants