Skip to content

fix timers on windows?#447

Open
JoTurk wants to merge 2 commits into
mainfrom
windows-timers-fix
Open

fix timers on windows?#447
JoTurk wants to merge 2 commits into
mainfrom
windows-timers-fix

Conversation

@JoTurk
Copy link
Copy Markdown
Member

@JoTurk JoTurk commented Dec 25, 2025

Description

apparently we have issues with rack on windows? according to @ValorZard

@codecov
Copy link
Copy Markdown

codecov Bot commented Dec 25, 2025

Codecov Report

❌ Patch coverage is 60.00000% with 16 lines in your changes missing coverage. Please review.
✅ Project coverage is 83.85%. Comparing base (767b9c4) to head (2dc7ec2).

Files with missing lines Patch % Lines
association.go 60.00% 14 Missing and 2 partials ⚠️

❌ Your patch check has failed because the patch coverage (60.00%) is below the target coverage (70.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #447      +/-   ##
==========================================
+ Coverage   83.79%   83.85%   +0.06%     
==========================================
  Files          52       52              
  Lines        4054     4058       +4     
==========================================
+ Hits         3397     3403       +6     
+ Misses        481      478       -3     
- Partials      176      177       +1     
Flag Coverage Δ
go 83.85% <60.00%> (+0.06%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@JoTurk JoTurk force-pushed the windows-timers-fix branch 6 times, most recently from daa2fdf to f9d372f Compare December 25, 2025 04:09
@JoTurk JoTurk force-pushed the windows-timers-fix branch from f9d372f to 9b5cfe9 Compare December 25, 2025 04:11
@ValorZard
Copy link
Copy Markdown

We can use https://github.com/basil00/WinDivert to maybe create a headless way of testing the network connection? Considering its the underlying library behind https://github.com/jagt/clumsy

@ValorZard
Copy link
Copy Markdown

Also for reference, here is the sample project that is suffering performance issues: https://github.com/ValorZard/ebiten-game-again-broken

Running this on clumsy with these settings cause massive amounts of lag
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants