Update ack_timer to RFC 9260#429
Conversation
Codecov Report❌ Patch coverage is
❌ Your patch check has failed because the patch coverage (69.23%) is below the target coverage (70.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## master #429 +/- ##
==========================================
+ Coverage 83.84% 83.85% +0.01%
==========================================
Files 51 51
Lines 3448 3457 +9
==========================================
+ Hits 2891 2899 +8
Misses 417 417
- Partials 140 141 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
655e193 to
cf92bf8
Compare
cf92bf8 to
43ec894
Compare
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the ackTimer to support configurable SACK (Selective Acknowledgement) delays per RFC 9260 requirements. The changes improve RFC compliance, fix spelling errors, enhance defensive programming around timer state management, and update documentation to reflect the correct RFC version.
- Added configurable SACK delay with proper validation bounds (0, 500ms]
- Improved defensive checks on
pendingcounter to prevent underflow - Updated documentation and corrected spelling mistakes
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
43ec894 to
086aa13
Compare
Description
Note that this doesn't currently allow for the delay to be configurable, but the clamp is there in case the default value changes to ensure correctness.
Reference issue
Resolves #428.