Skip to content

Restore Firefox compatibility#841

Merged
JoTurk merged 1 commit into
pion:v3from
aler9:fix/certreq-algs
Jun 6, 2026
Merged

Restore Firefox compatibility#841
JoTurk merged 1 commit into
pion:v3from
aler9:fix/certreq-algs

Conversation

@aler9
Copy link
Copy Markdown
Member

@aler9 aler9 commented Jun 6, 2026

Description

Patch #801 silently changed the way this library reacts to unknown signature algorithms - they were silently skipped before, now they cause a fatal error. This broke compatibiliy with remote peers that are advertising unhandled algorithms (like SHA256+DSA), and going all way to the top prevents Firefox from interacting with pion/webrtc.

This patch fixes the issue by restoring the old behavior of skipping unknown signature algorithms.

Reference issue

bluenviron/mediamtx#5838

@codecov
Copy link
Copy Markdown

codecov Bot commented Jun 6, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 82.87%. Comparing base (12eb398) to head (fd356c9).

Additional details and impacted files
@@            Coverage Diff             @@
##               v3     #841      +/-   ##
==========================================
+ Coverage   82.69%   82.87%   +0.18%     
==========================================
  Files         123      121       -2     
  Lines        7002     6930      -72     
==========================================
- Hits         5790     5743      -47     
+ Misses        806      787      -19     
+ Partials      406      400       -6     
Flag Coverage Δ
go 82.87% <100.00%> (+0.18%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@JoTurk
Copy link
Copy Markdown
Member

JoTurk commented Jun 6, 2026

hello @aler9.
damn, thank you for the fix, firefox also broke compatibility with us recently https://bugzilla.mozilla.org/show_bug.cgi?id=2033783 and it was one of the reasons we decided to freeze dtls 1.3 and new work from getting released as v3 and until dtls and browser interop is ready (I'll try to finish them this weekend) https://github.com/pion/browser-tests https://github.com/pion/dtls-interop

Can you make this PR target v3 branch? because main has breaking changes for dtls 1.3.

@aler9 aler9 changed the base branch from main to v3 June 6, 2026 09:21
Patch pion#801 silently changed the way this library reacts to unknown
signature algorithms - they were silently skipped before, now they
cause a fatal error. This broke compatibiliy with remote peers that are
advertising unhandled algorithms (like SHA256+DSA), and going all way
to the top prevents Firefox from interacting with pion/webrtc.

This patch fixes the issue by restoring the old behavior of skipping
unknown signature algorithms.
@aler9 aler9 force-pushed the fix/certreq-algs branch from e63367c to fd356c9 Compare June 6, 2026 09:22
@aler9
Copy link
Copy Markdown
Member Author

aler9 commented Jun 6, 2026

@JoTurk i've rebased against v3.

Copy link
Copy Markdown
Member

@JoTurk JoTurk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @aler9 and sorry about the bad patch, I'll release this, and retract the bad version.

@JoTurk JoTurk merged commit 0e3867b into pion:v3 Jun 6, 2026
16 checks passed
@JoTurk
Copy link
Copy Markdown
Member

JoTurk commented Jun 6, 2026

@aler9 released in v3.1.4.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants