Restore Firefox compatibility#841
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## v3 #841 +/- ##
==========================================
+ Coverage 82.69% 82.87% +0.18%
==========================================
Files 123 121 -2
Lines 7002 6930 -72
==========================================
- Hits 5790 5743 -47
+ Misses 806 787 -19
+ Partials 406 400 -6
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
hello @aler9. Can you make this PR target |
Patch pion#801 silently changed the way this library reacts to unknown signature algorithms - they were silently skipped before, now they cause a fatal error. This broke compatibiliy with remote peers that are advertising unhandled algorithms (like SHA256+DSA), and going all way to the top prevents Firefox from interacting with pion/webrtc. This patch fixes the issue by restoring the old behavior of skipping unknown signature algorithms.
|
@JoTurk i've rebased against v3. |
|
@aler9 released in v3.1.4. |
Description
Patch #801 silently changed the way this library reacts to unknown signature algorithms - they were silently skipped before, now they cause a fatal error. This broke compatibiliy with remote peers that are advertising unhandled algorithms (like SHA256+DSA), and going all way to the top prevents Firefox from interacting with pion/webrtc.
This patch fixes the issue by restoring the old behavior of skipping unknown signature algorithms.
Reference issue
bluenviron/mediamtx#5838