[Improvement] Allow OR condition with "match" expression by henriqueng · Pull Request #76 · pinterest/starrocks

henriqueng · 2026-01-22T20:37:04Z

Why I'm doing:

Starrocks returns the following error when using a match predicate (based on a column with GIN) in an "OR" query:

Match can only used as a pushdown predicate on column with GIN in a single query.

This only happens with OR queries. On the other hand, AND queries work fine.

What I'm doing:

Load roaring bitmap from inverted index for all match expressions that are not on root level in order to use them during evaluate, unblocking OR conditions with match expressions based on inverted index.

What type of PR is this:

Does this PR entail a change in behavior?

Yes, this PR will result in a change in behavior.
No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

Interface/UI changes: syntax, type conversion, expression evaluation, display information
Parameter changes: default values, similar parameters but with different default values
Policy changes: use new policy to replace old one, functionality automatically enabled
Feature removed
Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

I have added test cases for my bug fix or my new feature
This pr needs user documentation (for new or modified features or behaviors)
- I have added documentation for my new feature or new function
This is a backport pr

Bugfix cherry-pick branch check:

Signed-off-by: Henrique Duarte Lima <henrique@engduarte.com>

Signed-off-by: Martynov Maxim <martinov_m_s_@mail.ru> Signed-off-by: stdpain <drfeng08@gmail.com> Co-authored-by: stdpain <drfeng08@gmail.com>

Signed-off-by: alvin-celerdata <alvin.zhao@celerdata.com>

…8765) Signed-off-by: wangshifa.1 <wangshifa.1@jd.com>

Signed-off-by: alvin-celerdata <alvin.zhao@celerdata.com>

Signed-off-by: Kevin Cai <kevin.cai@celerdata.com>

…ickhouse (StarRocks#65825) Signed-off-by: xiaoxiaobinin <916352455@qq.com> Signed-off-by: stdpain <drfeng08@gmail.com>

…s#68764) Signed-off-by: Ratul Dawar <ratuldawar11@gmail.com>

Signed-off-by: zihe.liu <ziheliu1024@gmail.com>

…ks#68674) Signed-off-by: 絵空事スピリット <wanglichen@starrocks.com> Co-authored-by: Tony Xia <tony.xia@celerdata.com> Co-authored-by: 絵空事スピリット <wanglichen@starrocks.com>

…ns to required (StarRocks#68710)

…destroy (StarRocks#68801) Signed-off-by: luohaha <18810541851@163.com>

…index flush (StarRocks#68772) Signed-off-by: arvindksi274-ksolves <arvind.kandpal@ksolves.com>

…e meta (StarRocks#68781) Signed-off-by: srlch <linzichao@starrocks.com>

Signed-off-by: SevenJ <wenjun7j@gmail.com>

Signed-off-by: alvin-celerdata <alvin.zhao@celerdata.com>

…splitting (StarRocks#69152) Signed-off-by: luohaha <18810541851@163.com> Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>

…tarRocks#69149) Signed-off-by: silverbullet233 <3675229+silverbullet233@users.noreply.github.com>

…#68938) Signed-off-by: stdpain <drfeng08@gmail.com>

…ons (StarRocks#69170) Signed-off-by: stephen <stephen5217@163.com>

…tarRocks#69173) Signed-off-by: stephen <stephen5217@163.com>

…9137) Signed-off-by: stdpain <drfeng08@gmail.com>

Signed-off-by: SevenJ <wenjun7j@gmail.com>

…tarRocks#68480) Signed-off-by: MatthewH00 <1639097204@qq.com>

…e. (StarRocks#69063) Signed-off-by: edwinhzhang <edwinhzhang@tencent.com>

Signed-off-by: Henrique Duarte Lima <henrique@engduarte.com>

github-actions Bot added the title needs [type] label Jan 22, 2026

henriqueng force-pushed the support_disjunctions_with_match branch from e5e3273 to dd96a43 Compare January 23, 2026 23:58

github-actions Bot added the documentation Improvements or additions to documentation label Jan 23, 2026

[Improvement] Allow OR condition with "match" expr

9e72305

Signed-off-by: Henrique Duarte Lima <henrique@engduarte.com>

henriqueng force-pushed the support_disjunctions_with_match branch from dd96a43 to 9e72305 Compare January 24, 2026 00:09

chore: rerun CI

6760298

Signed-off-by: Henrique Duarte Lima <henrique@engduarte.com>

henriqueng force-pushed the support_disjunctions_with_match branch 2 times, most recently from b3117c9 to c97b247 Compare January 30, 2026 23:39

github-actions Bot removed the documentation Improvements or additions to documentation label Jan 30, 2026

henriqueng force-pushed the support_disjunctions_with_match branch from c97b247 to c219592 Compare January 30, 2026 23:41

[Tool] Fix multiple artifact path (StarRocks#68757)

111c57b

henriqueng force-pushed the support_disjunctions_with_match branch 2 times, most recently from fe3aa7a to 5553c65 Compare January 31, 2026 02:39

Add InvertedIndexFallbackPredicate

e24fa5c

Signed-off-by: Henrique Duarte Lima <henrique@engduarte.com>

henriqueng force-pushed the support_disjunctions_with_match branch from 5553c65 to e24fa5c Compare January 31, 2026 02:41

dolfinus and others added 15 commits January 30, 2026 20:55

[Feature] Introduce customSessionName (StarRocks#59754)

0ffab5c

Signed-off-by: Martynov Maxim <martinov_m_s_@mail.ru> Signed-off-by: stdpain <drfeng08@gmail.com> Co-authored-by: stdpain <drfeng08@gmail.com>

[UT] Add base UT module (StarRocks#68753)

ce7a307

Signed-off-by: alvin-celerdata <alvin.zhao@celerdata.com>

[Refactor] Move base util into base module (StarRocks#68763)

17f2e98

Signed-off-by: alvin-celerdata <alvin.zhao@celerdata.com>

[Refactor] Move more to base (StarRocks#68767)

4c55a55

Signed-off-by: alvin-celerdata <alvin.zhao@celerdata.com>

[Refactor] Move testutil to base (StarRocks#68770)

83b03ca

Signed-off-by: alvin-celerdata <alvin.zhao@celerdata.com>

[BugFix] Fix PocoHttpClient wrong timeout parameter used (StarRocks#6…

9f33d00

…8765) Signed-off-by: wangshifa.1 <wangshifa.1@jd.com>

[Refactor] Opt common module (StarRocks#68771)

711c6c2

Signed-off-by: alvin-celerdata <alvin.zhao@celerdata.com>

[Enhancement] staros version to v4.1-rc01 (StarRocks#68705)

ec082aa

Signed-off-by: Kevin Cai <kevin.cai@celerdata.com>

[BugFix] Fix exception when read DateTime('Asia/Shanghai') Type of Cl…

44468b9

…ickhouse (StarRocks#65825) Signed-off-by: xiaoxiaobinin <916352455@qq.com> Signed-off-by: stdpain <drfeng08@gmail.com>

[BugFix] Strip trailing slash from repository location path (StarRock…

2a8dff2

…s#68764) Signed-off-by: Ratul Dawar <ratuldawar11@gmail.com>

[UT] Fix unstable SQL Test cases (StarRocks#68780)

cb37544

Signed-off-by: zihe.liu <ziheliu1024@gmail.com>

[Enhancement] Add impersonate user for query detail http api (StarRoc…

79df62f

…ks#68674) Signed-off-by: 絵空事スピリット <wanglichen@starrocks.com> Co-authored-by: Tony Xia <tony.xia@celerdata.com> Co-authored-by: 絵空事スピリット <wanglichen@starrocks.com>

[Enhancement] Modify iceberg position delete file file_path/pos colum…

5cce8e4

…ns to required (StarRocks#68710)

[BugFix] wait merge jobs finish before LoadSpillPipelineMergeContext …

cf15fda

…destroy (StarRocks#68801) Signed-off-by: luohaha <18810541851@163.com>

[BugFix] Fix CN crash caused by uncaught tenann::Error during vector …

7be125c

…index flush (StarRocks#68772) Signed-off-by: arvindksi274-ksolves <arvind.kandpal@ksolves.com>

srlch and others added 30 commits February 11, 2026 09:51

[Enhancement] add primary key encoding info into TabletSchema relativ…

e53c178

…e meta (StarRocks#68781) Signed-off-by: srlch <linzichao@starrocks.com>

[BugFix] iceberg cache weigher refine (StarRocks#69058)

953cf62

Signed-off-by: SevenJ <wenjun7j@gmail.com>

[Refactor] Opt Column 6 (StarRocks#69159)

548bbbf

Signed-off-by: alvin-celerdata <alvin.zhao@celerdata.com>

[BugFix] Fix large SST missing start_key in parallel compaction task …

d1af859

…splitting (StarRocks#69152) Signed-off-by: luohaha <18810541851@163.com> Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>

[BugFix] fix missing agg function when min/max stats rewrite failed (S…

c0e96ce

…tarRocks#69149) Signed-off-by: silverbullet233 <3675229+silverbullet233@users.noreply.github.com>

[Enhancement] support virtual column row_id and segment_id (StarRocks…

e79a73c

…#68938) Signed-off-by: stdpain <drfeng08@gmail.com>

[BugFix] Fix low-cardinality rewrite crash for LEAD/LAG window functi…

7590a9c

…ons (StarRocks#69170) Signed-off-by: stephen <stephen5217@163.com>

[BugFix] Fix case-insensitive partition lookup in query table copy (S…

560804b

…tarRocks#69173) Signed-off-by: stephen <stephen5217@163.com>

[Refactor] Refactor global lazy materialize rewrite rule (StarRocks#6…

f647414

…9137) Signed-off-by: stdpain <drfeng08@gmail.com>

[Refactor] refine iceberg cache code (StarRocks#69078)

57bb357

Signed-off-by: SevenJ <wenjun7j@gmail.com>

[Enhancement] add partition scan num limit when query external table (S…

b563025

…tarRocks#68480) Signed-off-by: MatthewH00 <1639097204@qq.com>

[BugFix] Fix projection loss in MV rewrite due to shared mutable stat…

ced50d7

…e. (StarRocks#69063) Signed-off-by: edwinhzhang <edwinhzhang@tencent.com>

Merge branch 'main' into support_disjunctions_with_match

941288f

Signed-off-by: Henrique Duarte Lima <henrique@engduarte.com>

run clang-format

5321e2b

Signed-off-by: Henrique Duarte Lima <henrique@engduarte.com>

Update test_inverted_index

baea1c8

Update segment_iterator.cpp

cca9c5f

Update column_expr_predicate.h

61829d1

Update column_expr_predicate.cpp

e032e06

Update builtin_inverted_index_iterator.cpp

3310bfd

Update builtin_inverted_index_iterator.h

f49c79f

Update clucene_inverted_reader.cpp

c7e0ee2

Update clucene_inverted_reader.h

f85abc1

Change column_name parameter type to string_view

b5595ec

Update inverted_index_iterator.h

4564335

Update inverted_reader.h

31549d6

Update builtin_inverted_index_iterator.cpp

5a09727

Update clucene_inverted_reader.h

8b34870

Update builtin_inverted_reader.h

41230df

Update builtin_inverted_reader.h

53b3ce1

Update inverted_index_iterator.cpp

18a8481

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Improvement] Allow OR condition with "match" expression#76

[Improvement] Allow OR condition with "match" expression#76
henriqueng wants to merge 161 commits into
pinterest:mainfrom
henriqueng:support_disjunctions_with_match

henriqueng commented Jan 22, 2026 •

edited

Loading

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

20 participants

Conversation

henriqueng commented Jan 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Why I'm doing:

What I'm doing:

What type of PR is this:

Checklist:

Bugfix cherry-pick branch check:

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

20 participants

henriqueng commented Jan 22, 2026 •

edited

Loading