feat(release): version from ECR + marker-ref baselines, not git tags - #23
Merged
Conversation
image/* and chart/* git tags accumulate ~80/day and tax Kargo's git
tag enumeration; ECR already holds the authoritative version record
(retention fixed in platform-gitops#1200). Next version is now the
highest X.Y.Z tag in the service's ECR repo plus one, and the
change-detection baseline moves from the last release tag to a single
mutable refs/releases/{image,chart}/<svc> marker ref — readable from
jobs without AWS credentials (discover-services, chart prepare) and
invisible to Kargo and the create-webhook. Legacy tags fall back as
baseline until each service releases once, and are still minted for
Dispatch correlation until the direct CI notification lands
(platform-gitops#1201 dependency 2).
Chart version resolution moves from the prepare job to the package
job, which holds the AWS credentials; the matrix no longer carries a
precomputed version.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
X.Y.Ztag + 1, probe-and-bump past collisions) instead of the latestimage/*/chart/*git tag — ECR is the version record now that retention actually works (platform-gitops#1200). The tag-reclaiming recovery loop is obsolete and removed.discover-servicesbuild gate and chart-release's change-skip, which run in jobs with no AWS credentials) with per-service mutable marker refsrefs/releases/{image,chart}/<svc>, force-advanced to the released SHA on each successful push. Not tags → invisible to Kargo's tag enumeration and the GitHubcreatewebhook, constant ref count. Fallback order: marker ref → legacy tag → rebuild, so migration self-heals as each service releases once.prepare(credential-less) topackage; the matrix no longer carries a precomputedversion.image/*/chart/*tags and the aggregated GitHub Releases are still minted — Dispatch correlates on thecreatewebhook until the direct CI notification lands. This is PR 1 of the platform-gitops#1201 sequence (stop-minting comes last).Test plan
actionlintclean (the repo's CI check)0.0.520), trade-writer (0.0.508), reconciler (0.0.530), nadex-oegw (0.0.435); empty repo (charts/data-hub) and missing repo both resolve to first-release0.0.1rev-parse --verifyfallback, diff-against-marker) proven in scratch bare/clone reposservice-template) and watch one release resolve its version from ECR and advance its marker ref — callers pin@main, so this propagates org-wide immediately🤖 Generated with Claude Code