Skip to content

ci(docker-release): pass GIT_SHA build-arg to image builds #20

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cbayram merged 1 commit into from
Jun 8, 2026
Merged

ci(docker-release): pass GIT_SHA build-arg to image builds #20

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions .github/workflows/docker-release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -184,6 +184,12 @@ jobs:
# for backend services). Dockerfiles that don't declare
# `ARG APP_VERSION` silently ignore it.
--build-arg "APP_VERSION=${version}"
# Stamp the git short-SHA too. Unlike the per-repo `0.0.X`
# version (a build-ID), the commit is identical iff the code is
# identical — the reliable "is this the same build?" signal for
# services on parallel lanes (e.g. trader-tools stable vs dev).
# Dockerfiles that don't declare `ARG GIT_SHA` silently ignore it.
--build-arg "GIT_SHA=${SHORT_SHA}"
)
if [ -n "${TARGET}" ]; then
buildx_args+=(--target "${TARGET}")
Expand Down