Use Effect idioms in diagnostics and keyed worker#2783
Draft
cursor[bot] wants to merge 1 commit into
Draft
Conversation
Co-authored-by: Julius Marminge <juliusmarminge@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Changed
Duration, repeat sampling withSchedule.spaced, and store/report the latest sampling error asOption.KeyedCoalescingWorkerqueue state to useOptioninstead ofnull/undefinedsentinels, preservingundefinedvalues as valid queued work.@effect/vitestassertstyle and added focused coverage for the new Option-backed paths.Why
These are small Effect idiom improvements that make monitor timing easier to test with Effect primitives and remove sentinel values from queue state, including fixing the edge case where an explicitly
undefinedqueued value would be dropped.UI Changes
None.
Checklist
Note
Use Effect idioms for Option types and scheduling in diagnostics and keyed worker
null/undefinedsentinel values withOptiontypes forlastErrorinProcessResourceMonitorand for key values inKeyedCoalescingWorker, fixing cases whereundefinedvalues were silently treated as absent.ProcessResourceMonitorwithEffect.repeat(Schedule.spaced(SAMPLE_INTERVAL))for cleaner scheduling.windowandbucketdurations to a minimum of 1 second inaggregateProcessResourceHistoryviaDuration.max.@effect/vitestassert API and adds coverage forundefinedenqueue andOption-mapped sampling errors.KeyedCoalescingWorkernow processes keys whose latest value isundefinedrather than skipping them;ProcessResourceMonitornow clamps sub-1s window/bucket inputs.Macroscope summarized bd57f3b.