tiup HTTP clients ignore NO_PROXY#2711
Open
Jaehui-Lee wants to merge 1 commit into
Open
Conversation
Contributor
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Contributor
|
Welcome @Jaehui-Lee! It looks like this is your first PR to pingcap/tiup 🎉 |
|
|
ti-chi-bot
Bot
added
the
size/L
NewHTTPClient and makeTransport set the proxy via http.ProxyURL, which ignores NO_PROXY and forces internal PD/TiKV requests through HTTP_PROXY, breaking `tiup cluster reload` behind a proxy. Resolve it via x/net/http/httpproxy so NO_PROXY is honored; the TIUP_INNER_HTTP_PROXY override is kept. Add unit tests. Signed-off-by: Jaehui-Lee <tkdoqr1234@gmail.com>
Jaehui-Lee
force-pushed
the
fix/2710-honor-no-proxy
branch
from
87e42d9 to
c0ed112
Compare
Jaehui-Lee
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2710