bazel: upgrade rules_go v0.61.1 by hawkingrei · Pull Request #69655 · pingcap/tidb

hawkingrei · 2026-07-03T09:35:37Z

What problem does this PR solve?

Issue Number: close #69656

Problem Summary:

What changed and how does it work?

upgrade rules_go

Check List

Tests

Unit test
Integration test
Manual test (add detailed scripts or steps below)
No need to test
- I checked and no code files have been changed.

Side effects

Performance regression: Consumes more CPU
Performance regression: Consumes more Memory
Breaking backward compatibility

Documentation

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

Summary by CodeRabbit

Chores
- Refreshed the pinned Bazel external dependencies used by builds, updating their download sources and integrity checks.
- Updated the Bazel rules setup to load additional C++ compatibility support during workspace initialization.
Configuration
- Updated Bazel configuration to disable/enforce bzlmod behavior for the common scope via a new .bazelrc setting.

ti-chi-bot · 2026-07-03T09:35:47Z

Hi @hawkingrei. Thanks for your PR.

I'm waiting for a pingcap member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

hawkingrei · 2026-07-03T09:36:05Z

/ok-to-test

ti-chi-bot · 2026-07-03T09:36:22Z

@hawkingrei: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

Details

In response to this:

/ok-to-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

coderabbitai · 2026-07-03T09:36:32Z

Note

Reviews paused

It looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the reviews.auto_review.auto_pause_after_reviewed_commits setting.

Use the following commands to manage reviews:

@coderabbitai resume to resume automatic reviews.
@coderabbitai review to trigger a single review.

Use the checkboxes below for quick actions:

▶️ Resume reviews
🔍 Trigger review

📝 Walkthrough

Walkthrough

The PR updates multiple Bazel external dependency pins in WORKSPACE and adds a shared --noenable_bzlmod setting in .bazelrc.

Changes

Bazel dependency and config update

Layer / File(s)	Summary
Update external archives `WORKSPACE`	Updates pinned checksums, strip prefixes, and download URLs for `platforms`, `bazel_features`, `bazel_skylib`, `io_bazel_rules_go`, `bazel_gazelle`, `rules_cc`, and `rules_proto`.
Set common bzlmod option `.bazelrc`	Adds `common --noenable_bzlmod` to the shared Bazel configuration.

Estimated code review effort: 2 (Simple) | ~10 minutes

Suggested reviewers: windtalker

Poem

A rabbit hops through build-file light,
New pins and flags all look just right.
The archives hum, the config sings,
With tidy checksums, newer springs. 🐇

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly summarizes the main change: upgrading rules_go to v0.61.1.
Description check	✅ Passed	The description includes the required issue link, change summary, tests, and release note section, though the problem summary is sparse.
Linked Issues check	✅ Passed	The PR upgrades rules_go to v0.61.1, matching the linked issue's requested objective.
Out of Scope Changes check	✅ Passed	The additional Bazel dependency bumps and config tweak appear tied to the rules_go upgrade rather than unrelated changes.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands.}

lance6716 · 2026-07-03T09:40:39Z

/ok-to-test

AilinKid · 2026-07-03T09:40:52Z

/ok-to-test

ti-chi-bot · 2026-07-03T09:41:08Z

[LGTM Timeline notifier]

Timeline:

2026-07-03 09:38:08.248240137 +0000 UTC m=+377829.948619540: ☑️ agreed by AilinKid.
2026-07-03 09:41:07.005504744 +0000 UTC m=+378008.705884147: ☑️ agreed by lance6716.

AilinKid · 2026-07-03T09:41:29Z

/skip-issue-check

AilinKid · 2026-07-03T09:45:45Z

/approve no-issue

ti-chi-bot · 2026-07-03T09:45:54Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: AilinKid, lance6716

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [AilinKid,lance6716]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

AilinKid · 2026-07-03T09:56:52Z

/retest-required

AilinKid · 2026-07-03T10:20:18Z

/retest-required

hawkingrei · 2026-07-03T14:22:06Z

/retest

Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>

Signed-off-by: Hawkingrei <hawking.rei@gmail.com>

hawkingrei · 2026-07-04T05:19:19Z

/retest

hawkingrei · 2026-07-05T02:34:35Z

/retest

ti-chi-bot · 2026-07-05T02:50:44Z

@hawkingrei: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
idc-jenkins-ci-tidb/build	`c6f3b94`	link	true	`/test build`
pull-build-next-gen	`c6f3b94`	link	true	`/test pull-build-next-gen`
idc-jenkins-ci-tidb/check_dev	`c6f3b94`	link	true	`/test check-dev`
idc-jenkins-ci-tidb/check_dev_2	`c6f3b94`	link	true	`/test check-dev2`
idc-jenkins-ci-tidb/unit-test	`c6f3b94`	link	true	`/test unit-test`
pull-unit-test-next-gen	`c6f3b94`	link	true	`/test pull-unit-test-next-gen`
pull-integration-realcluster-test-next-gen	`c6f3b94`	link	true	`/test pull-integration-realcluster-test-next-gen`

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

hawkingrei · 2026-07-05T02:56:58Z

/retet

ti-chi-bot Bot added do-not-merge/needs-linked-issue do-not-merge/needs-tests-checked release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jul 3, 2026

ti-chi-bot Bot added contribution This PR is from a community contributor. needs-ok-to-test Indicates a PR created by contributors and need ORG member send '/ok-to-test' to start testing. and removed do-not-merge/needs-tests-checked labels Jul 3, 2026

AilinKid approved these changes Jul 3, 2026

View reviewed changes

ti-chi-bot Bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Jul 3, 2026

ti-chi-bot Bot added ok-to-test Indicates a PR is ready to be tested. and removed needs-ok-to-test Indicates a PR created by contributors and need ORG member send '/ok-to-test' to start testing. labels Jul 3, 2026

lance6716 approved these changes Jul 3, 2026

View reviewed changes

ti-chi-bot Bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Jul 3, 2026

lance6716 added the skip-issue-check Indicates that a PR no need to check linked issue. label Jul 3, 2026

ti-chi-bot Bot removed the do-not-merge/needs-linked-issue label Jul 3, 2026

ti-chi-bot Bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jul 3, 2026

ti-chi-bot Bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jul 3, 2026

hawkingrei and others added 4 commits July 3, 2026 22:56

bazel: upgrade rules_go v0.61.1

b18fc36

Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>

bazel: upgrade platforms to 1.1.0

e3e020b

bazel: upgrade bazel-skylib to 1.8.1

ff6f5ae

update

bf55b64

Signed-off-by: Hawkingrei <hawking.rei@gmail.com>

hawkingrei force-pushed the rules_go_20260703 branch from 05000e5 to bf55b64 Compare July 3, 2026 14:58

bazel: rely on rules_go rules_cc dependency

252752a

bazel: sync before bazel build

c6f3b94

Uh oh!

Conversation

hawkingrei commented Jul 3, 2026 • edited by coderabbitai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What problem does this PR solve?

What changed and how does it work?

Check List

Release note

Summary by CodeRabbit

Summary by CodeRabbit

Uh oh!

ti-chi-bot Bot commented Jul 3, 2026

Uh oh!

hawkingrei commented Jul 3, 2026

Uh oh!

ti-chi-bot Bot commented Jul 3, 2026

Uh oh!

coderabbitai Bot commented Jul 3, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviews paused

Walkthrough

Changes

Uh oh!

lance6716 commented Jul 3, 2026

Uh oh!

AilinKid commented Jul 3, 2026

Uh oh!

ti-chi-bot Bot commented Jul 3, 2026

[LGTM Timeline notifier]

Uh oh!

AilinKid commented Jul 3, 2026

Uh oh!

AilinKid commented Jul 3, 2026

Uh oh!

ti-chi-bot Bot commented Jul 3, 2026

Uh oh!

AilinKid commented Jul 3, 2026

Uh oh!

AilinKid commented Jul 3, 2026

Uh oh!

hawkingrei commented Jul 3, 2026

Uh oh!

hawkingrei commented Jul 4, 2026

Uh oh!

hawkingrei commented Jul 5, 2026

Uh oh!

ti-chi-bot Bot commented Jul 5, 2026

Uh oh!

hawkingrei commented Jul 5, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

hawkingrei commented Jul 3, 2026 •

edited by coderabbitai Bot

Loading

coderabbitai Bot commented Jul 3, 2026 •

edited

Loading