Add --reasoning flag for models that support thinking/reasoning levels#393
Closed
ScuttleBot wants to merge 1 commit into
Closed
Add --reasoning flag for models that support thinking/reasoning levels#393ScuttleBot wants to merge 1 commit into
ScuttleBot wants to merge 1 commit into
Conversation
Contributor
Code Review SummaryStatus: No Issues Found | Recommendation: Merge The new commit adds
Files Reviewed (2 files)
Reviewed by claude-4.6-sonnet-20260217 · 116,618 tokens |
d3a0766 to
6b9abf0
Compare
Adds a --reasoning CLI argument to benchmark.py that gets passed through to the OpenClaw agent's models.json configuration. This enables benchmarking models like inception/mercury-2 with different reasoning levels (low, medium, high). Changes: - benchmark.py: add --reasoning argument, pass to ensure_agent_exists() - lib_agent.py: accept reasoning param, apply to model config for both custom endpoints and standard OpenRouter flow
6b9abf0 to
48962f2
Compare
Contributor
Author
|
Closing this PR — PinchBench already has a |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a
--reasoningCLI argument to benchmark.py that gets passed through to the OpenClaw agent's models.json configuration. This enables benchmarking models like inception/mercury-2 with different reasoning levels (low, medium, high).Usage
# Run mercury-2 with medium reasoning python3 scripts/benchmark.py --model openrouter/inception/mercury-2 --reasoning mediumChanges
benchmark.py: add--reasoningargument, pass toensure_agent_exists()lib_agent.py: acceptreasoningparam, apply to model config for both custom endpoints and standard OpenRouter flowThe reasoning value is set on the model entry in
models.jsonand passed through to the provider API (e.g. OpenRouter'sreasoningparameter).