Fix dead links in README and CONTRIBUTING#1106
Open
blankse wants to merge 8 commits into
Open
Conversation
- Point the Contributing guide link to a relative path; the previous https://github.com/pimcore/data-hub/blob/master/CONTRIBUTING.md URL returned 404 because the `master` branch no longer exists. - Update the adapter documentation links from pimcore.com/docs/... to the canonical docs.pimcore.com/... domain to avoid the 301 redirect. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
- The php-cs-fixer link pointed to the `1.x` branch, which no longer exists upstream and returned 404. Replaced with a relative link. - Updated the feature-branch hint from `1.x` to the current default branch `2026.x`. - The PR target was described as the `master` branch, which no longer exists; replaced with "default branch". Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
blankse
changed the title
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
The README and CONTRIBUTING guide contain links and branch references that no longer resolve correctly, mostly because the
masterand1.xbranches no longer exist.Changes
README.md
https://github.com/pimcore/data-hub/blob/master/CONTRIBUTING.md, but themasterbranch no longer exists → 404. Replaced with a relative link./CONTRIBUTING.md, which always resolves against the ref being viewed.https://pimcore.com/docs/platform/..., which 301-redirects tohttps://docs.pimcore.com/platform/.... Updated to the canonical domain.CONTRIBUTING.md
1.xbranch, which no longer exists upstream → 404. Replaced with a relative link./.php-cs-fixer.dist.php.1.xto the current default branch2026.x.1.0to2026.1.masterbranch (gone) → replaced with "default branch".All other links (SonarCloud badge, internal
./doc/...links, GitHub issues, CLA assistant) were verified and are fine.🤖 Generated with Claude Code