Add missing DocumentElementType Renderlet#1005
Open
blankse wants to merge 4 commits into
Open
Conversation
blankse
changed the title
|
|
Adds a RenderletType GraphQL type and its query field config generator, modeled on the existing RelationsType, exposing the editable's _editableType/_editableName/id/type/subtype and its single relation target. Registers the generator service and baselines the new static() usage. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Extract a resolveRenderlet() helper for the simple editable fields so the repeated instanceof checks no longer live inside getInstance(), reducing its cognitive complexity below the threshold. Drop the unused resolver parameters from those fields and wrap the relation resolver signature to stay within the line-length limit. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds GraphQL support for the Renderlet document editable, which was previously missing from the document element types.
Introduces a new RenderletType exposing the editable's _editableType, _editableName, id, type, subtype and the referenced relation (resolved as an anytarget element), plus the corresponding Renderlet query field config generator and its service registration.