DocumentFolderType: Missing type and properties fields#1001
Merged
Conversation
blankse
changed the title
|
All document types have type and properties fields, but these were missing for folders. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Contributor
Author
|
@astapc Can you review this? |
Contributor
Author
|
@astapc Can you review this please? FYI @kingjia90 |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the GraphQL schema for document folders to align with other document types by exposing missing metadata fields, and it also refreshes the shipped Studio build artifacts (new build hash + updated manifest/public paths).
Changes:
- Add
typeandpropertiesfields toDocumentFolderTypeGraphQL type. - Regenerate/replace Studio build output under
src/Resources/public/studio/build/<hash>/and update manifests/entrypoints to reference the new build path.
Reviewed changes
Copilot reviewed 9 out of 24 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
src/GraphQL/DocumentType/DocumentFolderType.php |
Adds type and properties fields to the document folder GraphQL type. |
src/Resources/public/studio/build/ff839beb-e05c-42b7-8f6b-6b4dc202ddee/static/js/remoteEntry.js.LICENSE.txt |
New Studio build license bundle output. |
src/Resources/public/studio/build/ff839beb-e05c-42b7-8f6b-6b4dc202ddee/static/js/main.9c3ad8a2.js.LICENSE.txt |
New Studio build license bundle output. |
src/Resources/public/studio/build/ff839beb-e05c-42b7-8f6b-6b4dc202ddee/static/js/main.9c3ad8a2.js |
New Studio build main JS bundle output. |
src/Resources/public/studio/build/ff839beb-e05c-42b7-8f6b-6b4dc202ddee/static/js/async/840.4693a4bb.js.LICENSE.txt |
New Studio async chunk license bundle output. |
src/Resources/public/studio/build/ff839beb-e05c-42b7-8f6b-6b4dc202ddee/static/js/async/696.3b1d6da3.js.LICENSE.txt |
New Studio async chunk license bundle output. |
src/Resources/public/studio/build/ff839beb-e05c-42b7-8f6b-6b4dc202ddee/static/js/async/696.3b1d6da3.js |
New Studio async JS chunk output. |
src/Resources/public/studio/build/ff839beb-e05c-42b7-8f6b-6b4dc202ddee/static/js/async/__federation_expose_plugins.c4cf01bd.js.LICENSE.txt |
New Studio federation expose chunk license bundle output. |
src/Resources/public/studio/build/ff839beb-e05c-42b7-8f6b-6b4dc202ddee/static/js/async/__federation_expose_plugins.c4cf01bd.js |
New Studio federation expose chunk output. |
src/Resources/public/studio/build/ff839beb-e05c-42b7-8f6b-6b4dc202ddee/static/js/async/__federation_expose_default_export.87553f32.js.LICENSE.txt |
New Studio federation default export chunk license bundle output. |
src/Resources/public/studio/build/ff839beb-e05c-42b7-8f6b-6b4dc202ddee/static/js/async/__federation_expose_default_export.87553f32.js |
New Studio federation default export chunk output. |
src/Resources/public/studio/build/ff839beb-e05c-42b7-8f6b-6b4dc202ddee/static/js/109.62a4c31b.js.LICENSE.txt |
New Studio build vendor/license bundle output. |
src/Resources/public/studio/build/ff839beb-e05c-42b7-8f6b-6b4dc202ddee/mf-stats.json |
Updates Module Federation stats to new publicPath. |
src/Resources/public/studio/build/ff839beb-e05c-42b7-8f6b-6b4dc202ddee/mf-manifest.json |
Updates Module Federation manifest to new publicPath. |
src/Resources/public/studio/build/ff839beb-e05c-42b7-8f6b-6b4dc202ddee/manifest.json |
Adds/updates build manifest listing bundle files and entrypoints. |
src/Resources/public/studio/build/ff839beb-e05c-42b7-8f6b-6b4dc202ddee/main.html |
Updates script tags to reference the new build hash path. |
src/Resources/public/studio/build/ff839beb-e05c-42b7-8f6b-6b4dc202ddee/exposeRemote.js |
Updates remoteEntry path to the new build hash. |
src/Resources/public/studio/build/ff839beb-e05c-42b7-8f6b-6b4dc202ddee/entrypoints.json |
Adds/updates entrypoints for the new build hash. |
src/Resources/public/studio/build/785fd5b2-5311-4070-9fc4-81949c904ac6/manifest.json |
Removes old build manifest (previous build hash). |
src/Resources/public/studio/build/785fd5b2-5311-4070-9fc4-81949c904ac6/entrypoints.json |
Removes old entrypoints (previous build hash). |
Comments suppressed due to low confidence (1)
src/Resources/public/studio/build/ff839beb-e05c-42b7-8f6b-6b4dc202ddee/mf-manifest.json:26
- The PR description is about adding missing
type/propertiesfields toDocumentFolderType, but this change set also updates the Studio bundle build output (new build hash + updatedpublicPath, plus many generated JS/manifest files). If this rebuild is intentional, the PR description should mention it; if not, these generated artifacts should be removed/split into a separate PR to keep the change scoped and reviewable.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
kingjia90
reviewed
Jun 23, 2026
Documents use a "key" path segment (Document::getKey()), not a "filename" like assets. The "filename" field was a leftover copied from AssetFolderType and resolved to null for document folders. Replace it with "key", matching ObjectFolderType. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
blankse
commented
Jun 23, 2026
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
All document types have type and properties fields, but these are missing for folders.