Skip to content

fix(install): capture tar extraction diagnostic output on darwin-arm64 (PILOT-221) #348

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
matthew-pilot wants to merge 1 commit into
base: main
Choose a base branch
from
+22 −5
Open

fix(install): capture tar extraction diagnostic output on darwin-arm64 (PILOT-221) #348

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 22 additions & 5 deletions install.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -302,18 +302,35 @@ if [ -n "$TAG" ]; then
if tar --version 2>/dev/null | grep -q 'GNU tar'; then
TAR_SAFE="--no-same-owner --no-same-permissions"
fi
# macOS bsdtar can fail silently on GitHub gzip archives.
# Try tar -xzf first; fall back to gunzip|tar on failure.
if ! tar -xzf "$TMPDIR/$ARCHIVE" -C "$TMPDIR" $TAR_SAFE 2>/dev/null || [ ! -f "$TMPDIR/pilotctl" ]; then
# macOS bsdtar can fail silently on GitHub gzip archives
# (e.g. darwin-arm64 — bsdtar reads the gzip format header
# differently and may produce no output without reporting
# an error). Try tar -xzf first; fall back to gunzip|tar on
# failure. Both stderr paths are preserved in TAR_ERR so the
# final error message includes diagnostic output.
TAR_ERR=$(mktemp "${TMPDIR}/tar_err.XXXXXX")
EXTRACT_OK=false
if tar -xzf "$TMPDIR/$ARCHIVE" -C "$TMPDIR" $TAR_SAFE 2>"$TAR_ERR" && [ -f "$TMPDIR/pilotctl" ]; then
EXTRACT_OK=true
else
echo " tar -xzf failed or produced no output; trying gunzip fallback..."
gunzip -c "$TMPDIR/$ARCHIVE" | tar -x $TAR_SAFE -C "$TMPDIR"
if gunzip -c "$TMPDIR/$ARCHIVE" 2>"$TAR_ERR" | tar -x $TAR_SAFE -C "$TMPDIR" 2>>"$TAR_ERR"; then
if [ -f "$TMPDIR/pilotctl" ]; then
EXTRACT_OK=true
fi
fi
fi
if [ ! -f "$TMPDIR/pilotctl" ]; then
if [ "$EXTRACT_OK" != true ]; then
echo "Error: failed to extract binaries from ${ARCHIVE}"
if [ -s "$TAR_ERR" ]; then
echo " Diagnostic output from extract tool:"
sed 's/^/ /' "$TAR_ERR"
fi
echo "Try downloading manually from:"
echo " ${URL}"
exit 1
fi
rm -f "$TAR_ERR"
else
TAG=""
fi
Expand Down
Loading