Bump updater to v0.2.3 for fail-closed attestation#309
Merged
Conversation
The updater module v0.2.3 makes SLSA attestation verification fail closed when the gh CLI is absent (previously a silent no-op). Bumping the dependency ships this behavior to the auto-updater binary built by cmd/updater. The --skip-attestation flag (added in #307) continues to wire to updater.Config.SkipAttestation as the explicit opt-out for hosts genuinely without gh.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Bumps
github.com/pilot-protocol/updaterfrom v0.2.2 to v0.2.3 ingo.mod/go.sum.Why
cmd/updaterbuilds the auto-updater binary shipped to client daemons (Homebrew + auto-update). updater v0.2.3 makes SLSA attestation verification ofchecksums.txtfail closed when theghCLI is absent — previously this was a silent no-op ("gh absent => pass"), which disabled the entire provenance gate on headless production hosts (install.sh never installs gh). That gap collapsed auto-update integrity to "anyone with GitHub repo-write access can ship a malicious release."This bump is what actually ships the H5 fail-closed behavior to client daemons. The
--skip-attestationflag (added in #307) was already wired toupdater.Config.SkipAttestation, but the field was a passive opt-out until v0.2.3 introduced the fail-closed default.Verification
GOWORK=off go get github.com/pilot-protocol/updater@v0.2.3 && go mod tidy— go.mod now pins v0.2.3, go.sum updated.GOWORK=off go build ./cmd/updater/...— OKgo vet ./cmd/updater/...— OKgo test ./cmd/updater/...— PASSgofmt -l cmd/updater/— cleanConfig/Updater/Newsignatures;SkipAttestation boolfield unchanged). The only deltas are added test functions exercising the fail-closed path. No other change tocmd/updaterrequired.Scope
Dependency bump only — go.mod + go.sum (3 insertions, 3 deletions). No source changes.