Skip to content

fix(pilotctl): catalogue list shows headline only with always-on view pointer (PILOT-405) #261

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
matthew-pilot wants to merge 1 commit into from
Closed

fix(pilotctl): catalogue list shows headline only with always-on view pointer (PILOT-405) #261

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 7 additions & 5 deletions cmd/pilotctl/appstore_catalogue.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -255,6 +255,10 @@ func cmdAppStoreCatalogue(_ []string) {
name = fmt.Sprintf("%s (%s)", e.DisplayName, e.ID)
}
fmt.Printf("\n %s v%s\n", name, e.Version)
// Headline: the catalogue's short one-line description acts as the
// headline/teaser. The full description lives in metadata.json and
// is shown by `pilotctl appstore view`.
fmt.Printf(" %s\n", e.Description)
// Teaser line: vendor · categories · license · size — only the
// parts a v2 entry actually carries. v1 entries skip it entirely.
var bits []string
Expand All @@ -273,11 +277,9 @@ func cmdAppStoreCatalogue(_ []string) {
if len(bits) > 0 {
fmt.Printf(" %s\n", strings.Join(bits, " · "))
}
fmt.Printf(" %s\n", e.Description)
// Point at the new detail view when extended metadata is published.
if e.MetadataURL != "" {
fmt.Printf(" view: pilotctl appstore view %s\n", e.ID)
}
// Always point at the detail view — even without extended metadata
// the view command shows local install facts.
fmt.Printf(" view: pilotctl appstore view %s\n", e.ID)
fmt.Printf(" install: pilotctl appstore install %s\n", e.ID)
}
}
Expand Down
Loading