fix(keyexchange): zero salvage plaintext on evict (PILOT-146)#221
Merged
Conversation
RecordSalvage trims aged entries from the head and bounds size by dropping the oldest, but those reslicings only move the slice header; the backing array still holds the cleartext until GC reaches it. Same for DrainSalvage's filter pass that drops aged entries without returning them. Explicitly zero each evicted entry's Plaintext bytes before the reslice, so a heap-walking attacker or use-after-free probe can't recover plaintext that was supposed to be ephemeral.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Three eviction paths (aged-head trim, size bound, drain filter) now zero the plaintext bytes before dropping the slice reference.