Skip to content

[diffs] Fix keyboard focus on virtualized scroll#771

Merged
amadeus merged 1 commit into
mainfrom
amadeus/firefox-pg-up-down
Jun 3, 2026
Merged

[diffs] Fix keyboard focus on virtualized scroll#771
amadeus merged 1 commit into
mainfrom
amadeus/firefox-pg-up-down

Conversation

@amadeus
Copy link
Copy Markdown
Member

@amadeus amadeus commented Jun 3, 2026

Fixes #753

Ensure focus stays captured when scrolling the virtualized list.

Ensure focus stays captured when virtualizing
@vercel
Copy link
Copy Markdown

vercel Bot commented Jun 3, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
pierre-docs-diffshub Ready Ready Preview Jun 3, 2026 12:55am
pierre-docs-trees Ready Ready Preview Jun 3, 2026 12:55am
pierrejs-diff-demo Ready Ready Preview Jun 3, 2026 12:55am
pierrejs-docs Ready Ready Preview Jun 3, 2026 12:55am

Request Review

@amadeus amadeus changed the title [diffs] [diffs] Fix keyboard focus on virtualized scroll Jun 3, 2026
Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 6a4910a170

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread packages/diffs/src/components/CodeView.ts
@amadeus amadeus merged commit 0befc3f into main Jun 3, 2026
12 checks passed
@amadeus amadeus deleted the amadeus/firefox-pg-up-down branch June 3, 2026 00:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bug: Firefox: Page Up / Page Down stop working

1 participant