Rework mute mode: explicit panel toggle, mode-gated right-click#58
Open
phyceClaw wants to merge 1 commit into
Open
Rework mute mode: explicit panel toggle, mode-gated right-click#58phyceClaw wants to merge 1 commit into
phyceClaw wants to merge 1 commit into
Conversation
Previously, right-click "Listen" on an actor silently called setListenMode(true), flipping the global mute system from blocklist to allowlist mode. Users repeatedly hit this by accident and ended up with "everyone but this person" muted, with no obvious way back. Now: - A new "Mute Settings" section in the plugin panel exposes the mode toggle. This is the only place the mode flips, and the change persists immediately via muteManager.saveConfig(). - The right-click sub-menu shows only mode-appropriate actions: - Blocklist mode: Mute / Unmute - Allowlist mode: Listen / Unlisten - Listen-click no longer flips mode behind the user's back. - The old "Stop Listen Mode" sub-entry is removed — the panel owns the mode now. Switching modes preserves both lists (no auto clearListens), so users don't lose their settings when toggling. Files touched: - MainSettingsPanel: inject MuteManager, add buildMuteModeSegment(). - MenuEventHandler: gate the primary menu entry by mode, remove the silent setListenMode(true) and "Stop Listen Mode" branch.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Right-clicking "Listen" on a player or NPC currently calls `setListenMode(true)` behind the scenes, flipping the entire mute system from blocklist (default) to allowlist mode. This is the most common confusion report about the plugin — users want to listen to one person and end up silencing everyone else with no obvious recovery path.
This PR makes the mode an explicit, panel-driven setting and removes the silent flip:
The `MuteManager` API is unchanged; only the call sites for `setListenMode` move. `isNpcAllowed` / `isUsernameAllowed` continue to honor the active mode for the speech path.
Closes Asana task "rework mute system: explicit allow/block toggle in panel".
Out of scope
Test plan
🤖 Generated with Claude Code
On behalf of @phyce