Suppress NPC overhead while NPC dialog is open#56
Open
phyceClaw wants to merge 1 commit into
Open
Conversation
phyceClaw
force-pushed
the
qol/suppress-overhead-during-dialog
branch
7 times, most recently
from
May 24, 2026 22:38
eb7e46b to
7eeb9f3
Compare
When you talk to an NPC, the dialog widget plays through TTS while the same NPC's overhead chatter often fires from the same event tick. This causes duplicate audio for the same line. Add a config toggle (default on) that skips the NPC overhead path while DIALOG_NPC_TEXT is visible.
phyceClaw
force-pushed
the
qol/suppress-overhead-during-dialog
branch
from
May 25, 2026 00:31
7eeb9f3 to
9b1bd48
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When you talk to an NPC, the dialog widget plays through TTS at the same time the NPC's overhead chatter often fires from the same event tick, producing duplicate audio of the same line.
Adds a config toggle (default on) in the Speech Generation section that skips the NPC overhead path while
DIALOG_NPC_TEXTis currently visible. NPC dialog itself, player dialog, and overhead from other NPCs all behave unchanged.Closes Asana task "When in dialog with an npc, don't also TTS the overhead text that the npc might say".
Test plan
🤖 Generated with Claude Code
On behalf of @phyce