Fix ActivityLog perf: incremental append + cap in-memory entries#9
Open
phyceClaw wants to merge 1 commit into
Open
Fix ActivityLog perf: incremental append + cap in-memory entries#9phyceClaw wants to merge 1 commit into
phyceClaw wants to merge 1 commit into
Conversation
mergeEntries rebuilt a Map and full-sorted entries on every appended event (O(n log n) per event, thrashes under log bursts). Append live entries in order with an id de-dupe instead, keeping the full merge only for bulk load-older/initial paths. Cap in-memory entries so a long session no longer grows unboundedly (older entries remain in the backing .jsonl and reload on demand). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ActivityLog.vuerebuilt a Map and full-sortedentrieson everyactivity.appendedevent — O(n log n) per event, which thrashes under a burst of log events. Andentriesgrew unboundedly for the lifetime of the window..jsonland reload via load-older.Existing filters, chain grouping,
focusChaindeep-link, and scroll-triggered load-older are preserved.Testing
See PR notes re: whether a full
npm run buildcould run in this environment.🤖 Generated with Claude Code