Fix Piper subprocess engine robustness#7
Open
phyceClaw wants to merge 1 commit into
Open
Conversation
- Return on Start() failure in Generate instead of proceeding against a model that failed to start - Guard the Piper.models map with a mutex (was a data race / nil-map panic risk across Start/Stop/Generate/GetProcessID) - Bound the stderr-scanning goroutine so a dead or silent subprocess can no longer hang Generate forever (buffered signal + timeout/exit) - Remove leftover debug logs Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
In
app/tts/engine/piper/piper.go:Generatediscarded the result ofStart()and proceeded even when the model failed to start. Now returns the error.modelsmap:Start/Stop/Generate/GetProcessIDaccessed the map with no synchronization. Guarded with a mutex." sec)"line via an unbuffered channel, andGenerateblocked on it with no timeout — a dead/silent subprocess hung forever. Now bounded (buffered signal + timeout/exit).Testing
CGO_ENABLED=1 go build ./app/...passes;go vetclean.🤖 Generated with Claude Code