Harden TTS engine HTTP clients#6
Open
phyceClaw wants to merge 1 commit into
Open
Conversation
- Add request timeouts to ElevenLabs and OpenAI HTTP clients (a hung endpoint no longer blocks a pooled instance forever) - Send the Gemini API key via the x-goog-api-key header instead of a URL query param (avoids leaking the key into logs/proxies/errors) - Reuse a single Google TextToSpeech client instead of creating one per request Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
&http.Client{}with no timeout; a hung endpoint blocked the pooled instance indefinitely. Added request timeouts (matching Gemini).?key=..., leaking into logs/proxies/error bodies. Now sent via thex-goog-api-keyheader.texttospeech.Clientwas created on every request; now created once and reused.Testing
CGO_ENABLED=1 go build ./app/...passes;go vetclean.🤖 Generated with Claude Code