Propagate errors in audio combine pipeline; init speaker once#5
Open
phyceClaw wants to merge 1 commit into
Open
Propagate errors in audio combine pipeline; init speaker once#5phyceClaw wants to merge 1 commit into
phyceClaw wants to merge 1 commit into
Conversation
CombineWAVFiles discarded ResampleBuffer/ChangeChannelCount/ ChangeBitDepth errors and appended un-converted buffers, corrupting combined output; it also returned nil after os.Create/encoder failures. Now propagates these errors. Close each source file per iteration instead of deferring in the loop (fd leak). Guard the beep speaker init with sync.Once. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
In
app/common/audio/audio.go,CombineWAVFilesswallowed errors:os.Create/encoder.Write/encoder.Closeerrors were logged but the function returnednil. Now propagated.defer-closed inside the loop (fd leak); now closed per iteration.In
player/player.go, the global beep speaker was re-initialized on everyPlayAudioFile; now guarded withsync.Once.Testing
CGO_ENABLED=1 go build ./app/...passes;go vetclean.🤖 Generated with Claude Code