Fix config path lookup for fields with omitempty json tags#2
Open
phyceClaw wants to merge 1 commit into
Open
Conversation
findFieldByJSONTag compared the full struct tag instead of the name before the comma, so fields tagged json:"x,omitempty" (server, audioCache, ...) could never be resolved by SetValueToPath/ GetValueFromPath, silently breaking config PATCH for those fields. Also fix a malformed json:"engines, omitempty" tag (stray space). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
findFieldByJSONTagcompared the full struct tag (e.g.server,omitempty) instead of the name before the comma, so any config field taggedjson:"x,omitempty"could not be resolved bySetValueToPath/GetValueFromPath. This silently broke config updates for fields likeserverandaudioCache.,and match only the name (mirrors the existing logic inschema.go).json:"engines, omitempty"tag (stray space disabled omitempty).Testing
CGO_ENABLED=1 go build ./...passes;go vetclean.🤖 Generated with Claude Code