Frontend correctness fixes#14
Open
phyceClaw wants to merge 1 commit into
Open
Conversation
- Remove debug console.logs that dumped full config (may contain keys) - Remove leaked beforeunload listener on Settings unmount - Re-enable notifications via try/finally so a thrown preview cannot leave notifications permanently disabled - Declare monaco-editor as an explicit dependency (was phantom) Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Small, low-risk frontend fixes (no dependency upgrades):
Settings.vueandFooter.vue.beforeunloadlistener:Settings.vueadded it on mount with no removal, stacking duplicates across navigation. Now removed on unmount.Playleft them disabled forever. Now re-enabled viatry/finally.monaco-editor: it was imported directly but only present transitively (phantom dep). Now declared inpackage.json.Testing
npm run build(vue-tsc --noEmit && vite build) passes.🤖 Generated with Claude Code