Respect context cancellation in Piper subprocess streaming#13
Open
phyceClaw wants to merge 1 commit into
Open
Conversation
Synthesize forwarded ctx only in native mode; the subprocess streamUtterance path blocked on sentinel/stderrClosed with no cancellation, so a stuck piper process could not be cancelled on session supersession. Select on ctx.Done() in the blocking waits and abandon the in-flight utterance cleanly on cancel. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
On the python-integration branch,
piper.Synthesizeforwardedctxonly in native mode. The subprocessstreamUtterancepath blocked onsentinel/stderrClosedwith no cancellation, so a stuck piper process could not be cancelled when a session was superseded (only playback unblocked).The blocking waits now
selectonctx.Done()and abandon the in-flight utterance cleanly on cancellation, matching how the Python engine already handlesctx.Testing
go test -race ./app/tts/engine/piper/... ./app/common/audio/...passes (skips noted where a piper binary/model is unavailable).🤖 Generated with Claude Code