Make audio stream apply real backpressure instead of erroring#10
Open
phyceClaw wants to merge 1 commit into
Open
Make audio stream apply real backpressure instead of erroring#10phyceClaw wants to merge 1 commit into
phyceClaw wants to merge 1 commit into
Conversation
StreamWriter.Write returned ErrStreamLimitReached once the elastic queue passed 64 MiB, which aborted valid long syntheses that buffer ahead via dispatchFutures. Write now blocks on the cond until the consumer drains space, and only returns an error if the stream is closed/errored while waiting. Tests updated for the new semantic. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
StreamWriter.WritereturnedErrStreamLimitReachedonce the elastic queue exceeded 64 MiB. BecausedispatchFuturespre-produces whole utterances ahead of playback, a long synthesis legitimately buffers ahead and could abort mid-stream.Writenow blocks (waiting on the existingsync.Cond) until the consumer drains space, giving real backpressure while still bounding memory. It returns an error only if the stream is closed/errored while waiting, so closing always unblocks a stalled producer. Tests updated: writer blocks then proceeds after a read; closing unblocks a blocked writer.Testing
go test -race ./app/common/audio/...passes (output in review).🤖 Generated with Claude Code