Harden HTTP server auth: default-deny admin, constant-time compare#1
Open
phyceClaw wants to merge 1 commit into
Open
Harden HTTP server auth: default-deny admin, constant-time compare#1phyceClaw wants to merge 1 commit into
phyceClaw wants to merge 1 commit into
Conversation
- AdminAuthMiddleware now returns 403 when no admin key is configured instead of granting access to /config (which exposes API keys) - Use crypto/subtle.ConstantTimeCompare for all token checks - Document the intentional unauthenticated mode on AuthMiddleware Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Hardens the HTTP server auth middleware.
AdminAuthMiddlewaregranted full access to/config(read/write API keys, engine paths) when no admin key was configured. It now returns 403 until an admin key is set.==(timing-unsafe); now usecrypto/subtle.ConstantTimeCompare.Testing
CGO_ENABLED=1 go build ./...passes;go vetclean.🤖 Generated with Claude Code